From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756386AbcHYWM4 (ORCPT ); Thu, 25 Aug 2016 18:12:56 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:2785 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751033AbcHYWMz (ORCPT ); Thu, 25 Aug 2016 18:12:55 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 25 Aug 2016 13:45:39 -0700 Subject: Re: [PATCH 2/6] i2c: tegra: Remove non device-tree support To: Wolfram Sang References: <1470910620-9898-1-git-send-email-jonathanh@nvidia.com> <1470910620-9898-3-git-send-email-jonathanh@nvidia.com> <20160825193314.GB1614@katana> CC: Laxman Dewangan , Stephen Warren , Thierry Reding , "Alexandre Courbot" , , , From: Jon Hunter Message-ID: <1010511e-baa6-2792-90a4-30fc49628de8@nvidia.com> Date: Thu, 25 Aug 2016 21:49:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160825193314.GB1614@katana> X-Originating-IP: [10.26.11.206] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/08/16 20:33, Wolfram Sang wrote: > * PGP Signed by an unknown key > > On Thu, Aug 11, 2016 at 11:16:56AM +0100, Jon Hunter wrote: >> Tegra has only supported device-tree for platform/board configuration >> for quite some time now and so simplify the Tegra I2C driver by dropping >> code for non device-tree platforms/boards. >> >> Signed-off-by: Jon Hunter > > cppcheck rightfully says: > > drivers/i2c/busses/i2c-tegra.c:854: style: Variable 'i2c_dev.hw' is reassigned a value before the old one has been used. > > Dropping the patches... Yes good catch. I will fix that. Cheers Jon -- nvpublic