From: Steve Lord <lord@sgi.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Alexander Viro <viro@math.psu.edu>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: ext3 umount oops in 2.5.2-pre10
Date: 09 Jan 2002 12:42:40 -0600 [thread overview]
Message-ID: <1010601760.29727.138.camel@jen.americas.sgi.com> (raw)
It looks like ext3 does not work if you do not use an external
journal device - the journal_bdev field is not initialized and
ext3_put_super goes belly up:
At the very least it needs this:
===========================================================================
Index: linux/fs/ext3/super.c
===========================================================================
--- /usr/tmp/TmpDir.13226-0/linux/fs/ext3/super.c_1.6 Wed Jan 9 12:38:48 2002
+++ linux/fs/ext3/super.c Wed Jan 9 12:26:00 2002
@@ -429,7 +429,7 @@
J_ASSERT(list_empty(&sbi->s_orphan));
invalidate_bdev(sb->s_bdev, 0);
- if (sbi->journal_bdev != sb->s_bdev) {
+ if (sbi->journal_bdev && (sbi->journal_bdev != sb->s_bdev)) {
/*
* Invalidate the journal device's buffers. We don't want them
* floating about in memory - the physical journal device may
--
Steve
next reply other threads:[~2002-01-09 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-09 18:42 Steve Lord [this message]
2002-01-09 22:17 ` Alessandro Suardi
2002-01-09 23:47 ` Alessandro Suardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1010601760.29727.138.camel@jen.americas.sgi.com \
--to=lord@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®