mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steve Lord <lord@sgi.com>
To: Chris Wedgwood <cw@f00f.org>
Cc: Jeff Garzik <garzik@havoc.gtf.org>, Chris Mason <mason@suse.com>,
	Andrea Arcangeli <andrea@suse.de>,
	Andrew Morton <akpm@zip.com.au>, Ricardo Galli <gallir@uib.es>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: O_DIRECT fails in some kernel and FS
Date: 04 Feb 2002 09:15:30 -0600	[thread overview]
Message-ID: <1012835730.26397.519.camel@jen.americas.sgi.com> (raw)
In-Reply-To: <20020203224406.GA17396@tapu.f00f.org>
In-Reply-To: <1012597538.26363.443.camel@jen.americas.sgi.com> <20020202093554.GA7207@tapu.f00f.org> <234710000.1012674008@tiny> <20020202205438.D3807@athlon.random> <242700000.1012680610@tiny> <3C5C4929.5080403@sgi.com> <20020202155028.B26147@havoc.gtf.org> <3C5D3DE9.4080503@sgi.com> <20020203140926.GA14532@tapu.f00f.org> <3C5D51A0.4050509@sgi.com>  <20020203224406.GA17396@tapu.f00f.org>

On Sun, 2002-02-03 at 16:44, Chris Wedgwood wrote:
> On Sun, Feb 03, 2002 at 09:05:04AM -0600, Stephen Lord wrote:
> 
>     but page faults are not blocked out for the duration of the I/O so
>     the coherency is weak.
> 
> I was thinking this would also be goof, basically invalidate those
> pages and remove them from the VMAs, marking them as unusable pending
> IO completion --- the logic her being if you were to fault on an
> invalidated page during IO you deserve to block indefinitely until the
> IO completes.
> 
>     However, if an application is doing a combination of mmapped and
>     direct I/O to a file at the same time, then it should generally
>     have some form of user space synchronization anyway.
> 
> I hadn't considered that.  I imagined an application doing either but
> not both, and the kernel enforcing this.  However, in the case when
> you want to mmap a large file, you may want to manipulate some pages
> using mmap whilst writing others with O_DIRECT.  Although, in such
> cases arguably you could using multiple mapping's.
> 
> 

If an application is single threaded then it cannot be doing both at
the same time - so all we need to do is flush and invalidate mappings
at the start of I/O. This is really only needed for the range covered by
the direct read/write.

If an application is multithreaded and is doing mmap and direct I/O
from different threads without doing its own synchronization, then it
is broken, there is no ordering guarantee provided by the kernel as
to what happens first.

> 
>    --cw

Steve

-- 

Steve Lord                                      voice: +1-651-683-3511
Principal Engineer, Filesystem Software         email: lord@sgi.com

  parent reply	other threads:[~2002-02-04 15:19 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-01 20:37 Ricardo Galli
2002-02-01 20:44 ` Andrew Morton
2002-02-01 20:49   ` Ricardo Galli
2002-02-01 20:57     ` Andrew Morton
2002-02-02 17:14   ` Christoph Hellwig
2002-02-01 21:05 ` Steve Lord
2002-02-02  9:35   ` Chris Wedgwood
2002-02-02 10:25     ` Hans Reiser
2002-02-02 15:24   ` Chris Mason
2002-02-02 18:20   ` Chris Mason
2002-02-02 19:54     ` Andrea Arcangeli
2002-02-02 20:10     ` Chris Mason
2002-02-02 20:16       ` Stephen Lord
2002-02-02 20:50         ` Jeff Garzik
2002-02-03 13:40           ` Stephen Lord
2002-02-03 14:09             ` Chris Wedgwood
2002-02-03 15:05               ` Stephen Lord
2002-02-03 22:44                 ` Chris Wedgwood
2002-02-04 15:04                   ` Jeff Garzik
2002-02-04 15:21                   ` Chris Mason
2002-02-04 15:15                 ` Steve Lord [this message]
2002-02-04 15:46                   ` Alan Cox
2002-02-04 16:02                     ` Steve Lord
2002-02-04 18:22                       ` Daniel Phillips
2002-02-04 19:11                       ` Steve Lord
2002-02-04 18:29                     ` Joel Becker
2002-02-04 18:49                       ` Jeff Garzik
2002-02-04 18:55                         ` Joel Becker
2002-02-04 19:16                           ` Jeff Garzik
     [not found] <E16WkQj-0005By-00@antoli.uib.es.suse.lists.linux.kernel>
     [not found] ` <3C5AFE2D.95A3C02E@zip.com.au.suse.lists.linux.kernel>
     [not found]   ` <1012597538.26363.443.camel@jen.americas.sgi.com.suse.lists.linux.kernel>
     [not found]     ` <20020202093554.GA7207@tapu.f00f.org.suse.lists.linux.kernel>
     [not found]       ` <234710000.1012674008@tiny.suse.lists.linux.kernel>
     [not found]         ` <20020202205438.D3807@athlon.random.suse.lists.linux.kernel>
     [not found]           ` <242700000.1012680610@tiny.suse.lists.linux.kernel>
     [not found]             ` <3C5C4929.5080403@sgi.com.suse.lists.linux.kernel>
     [not found]               ` <20020202155028.B26147@havoc.gtf.org.suse.lists.linux.kernel>
2002-02-03  7:26                 ` Andi Kleen
2002-02-04 15:13                   ` Jeff Garzik
2002-02-04 15:31                   ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1012835730.26397.519.camel@jen.americas.sgi.com \
    --to=lord@sgi.com \
    --cc=akpm@zip.com.au \
    --cc=andrea@suse.de \
    --cc=cw@f00f.org \
    --cc=gallir@uib.es \
    --cc=garzik@havoc.gtf.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mason@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®