mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Larson <plars@austin.ibm.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Marcelo Tosati <marcelo@conectiva.com.br>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.4.18-rc2 Fix for get_pid hang
Date: 25 Feb 2002 07:41:30 -0600	[thread overview]
Message-ID: <1014644491.18245.471.camel@plars.austin.ibm.com> (raw)
In-Reply-To: <E16eQ4R-0003cZ-00@the-village.bc.nu>
In-Reply-To: <E16eQ4R-0003cZ-00@the-village.bc.nu>

On Fri, 2002-02-22 at 18:29, Alan Cox wrote:
> > This was made against 2.4.18-rc2 but applies cleanly against
> > 2.4.18-rc4.  This is a fix for a problem where if we run out of
> > available pids, get_pid will hang the system while it searches through
> > the tasks for an available pid forever.
> 
> Wouldn't it be a much cleaner patch to limit the maximum number of processes
> to less than the number of pids available. You seem to be fixing a non
> problem by adding branches to the innards of a loop.
> 
That was my original thought, but as Rik and WLI already pointed out, it
won't account for process groups, tgids, etc.  This isn't a purely
theoretical problem either, as we have run up against it many times.

Thanks,
Paul Larson


  parent reply	other threads:[~2002-02-25 13:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-22 22:29 Paul Larson
2002-02-23  0:29 ` Alan Cox
2002-02-23  0:26   ` Rik van Riel
2002-02-23  0:41   ` William Lee Irwin III
2002-02-25 13:41   ` Paul Larson [this message]
2002-02-25 14:20     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1014644491.18245.471.camel@plars.austin.ibm.com \
    --to=plars@austin.ibm.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®