From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755542Ab3EQMHr (ORCPT ); Fri, 17 May 2013 08:07:47 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:55049 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754032Ab3EQMHq (ORCPT ); Fri, 17 May 2013 08:07:46 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, arvind.chauhan@arm.com Subject: Re: [PATCH 0/3] CPUFreq Fixes for 3.10-rc2 Date: Fri, 17 May 2013 14:16:23 +0200 Message-ID: <10164364.7LZaY8si4T@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.9.0+; KDE/4.9.5; x86_64; ; ) In-Reply-To: References: <4482296.g7Mb85DDVP@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, May 17, 2013 10:13:37 AM Viresh Kumar wrote: > On 17 May 2013 02:21, Rafael J. Wysocki wrote: > > While I kind of understand why you want [3/3] to go into 3.10, I'm wondering > > about the other two patches. Why exactly are they needed now? > > First one: > > cpufreq: Add EXPORT_SYMBOL_GPL for have_governor_per_policy > > is required so that governors can be compiled as module. Otherwise they > may break.. I haven't tried that but I believe that is the case. Did you try to build them as modules? > For second one: > > cpufreq: governors: Move get_governor_parent_kobj() to cpufreq.c > > I was actually working on Android's Interactive governor (Where I enabled > same per-policy-instance of governor support), And i required this patch > for its working. Then I thought other platform specific governors present > in mainline might also use this routine and so must be pushed to cpufreq.c. > > Now, because this patch is around due to something which got > added in 3.10-rc1, its better to fix it in rcs only rather than fixing > it in 3.11. OK, thanks for the explanation. > I will trust your judgement here, push it for 3.10-rc if it looks okay to you. > > > And speaking of patch [3/3], if you paste kernel logs into changelogs, please > > remove the time stamps (unless they are relevant to the problem being fixed). > > Okay.. Will keep that in mind. Thanks! Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.