From: Robert Love <rml@tech9.net>
To: Bill Davidsen <davidsen@tmr.com>
Cc: Bob Miller <rem@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.5.7 acct.c oops
Date: 21 Mar 2002 16:34:49 -0500 [thread overview]
Message-ID: <1016746490.5659.2.camel@phantasy> (raw)
In-Reply-To: <Pine.LNX.3.96.1020321162155.18421A-100000@gatekeeper.tmr.com>
On Thu, 2002-03-21 at 16:26, Bill Davidsen wrote:
> Please help my education... after looking at the code, I don't see why
> the BUG_ON was removed rather than made dependent on SMP, assuming that
> the BK comment and my hasty reading of code actually mean that it did work
> for SMP.
>
> Is this a solid "can't happen" now and no test needed, or is a better
> test in the works, or ???
>
> I didn't try to compile it, so there may be something I'm totally
> missing.
While he could of wrapped the test dependent in #ifdef/#endif
CONFIG_SMP, the test really is not overly needed. It is more a result
of the previous code, which Bob Miller himself fixed up and then much
rewrote the locking for.
Since he recently did the cleanup (and even added that BUG_ON) I trust
he knows if we can remove it.
Robert Love
next prev parent reply other threads:[~2002-03-21 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-21 19:38 Bob Miller
2002-03-21 21:26 ` Bill Davidsen
2002-03-21 21:34 ` Robert Love [this message]
2002-03-21 22:00 ` Bob Miller
2002-03-22 15:25 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1016746490.5659.2.camel@phantasy \
--to=rml@tech9.net \
--cc=davidsen@tmr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rem@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®