mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Stefan Mätje" <Stefan.Maetje@esd.eu>
To: Seraphime Kirkovski <kirkseraph@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: linux-4.14-rc1/arch/x86/include/asm/uaccess.h: Missing include of <linux/sched.h>
Date: Tue, 19 Sep 2017 15:57:05 +0200	[thread overview]
Message-ID: <1017211f-607c-56fa-104f-0b1f49ebac40@esd.eu> (raw)
In-Reply-To: <20170919131234.7eznipb6b76lwo7u@macchiaveli>

Hi,

changing the include line to <linux/uaccess.h> solves the problem for me.

Thank you for taking the time to look into this.

Best regards,
	Stefan Mätje

Am 19.09.2017 um 15:12 schrieb Seraphime Kirkovski:
> Hi,
> 
>> ./arch/x86/include/asm/uaccess.h: In function ‘set_fs’:
>> ./arch/x86/include/asm/uaccess.h:31:9: error: dereferencing pointer to
>> incomplete type
> 
> I can reproduce your problem by including <asm/uaccess.h>, but not with 
> <linux/uaccess.h>.
> 
> 	#include <asm/uaccess.h>
> 	//#include <linux/uaccess.h> does compile
> 	#include <linux/module.h>

My code doesn't use set_fs() but it is only in the header.

> If my memory is any good, direct inclusion of <asm/uaccess.h> was 
> deprecated in 4.12 and new code should use <linux/uaccess.h>

I did miss this deprecation.

> Thanks,
> Seraphime Kirkovski
> 

      reply	other threads:[~2017-09-19 13:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19 12:21 Stefan Mätje
2017-09-19 13:12 ` Seraphime Kirkovski
2017-09-19 13:57   ` Stefan Mätje [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1017211f-607c-56fa-104f-0b1f49ebac40@esd.eu \
    --to=stefan.maetje@esd.eu \
    --cc=kirkseraph@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®