From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DB2EC433F5 for ; Mon, 21 Mar 2022 11:41:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346830AbiCULnE (ORCPT ); Mon, 21 Mar 2022 07:43:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346823AbiCULnA (ORCPT ); Mon, 21 Mar 2022 07:43:00 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 19615154045 for ; Mon, 21 Mar 2022 04:41:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647862895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5IFZqINZubaQIrhPbpcFTVJX7mnUBlxWKhJ9rwfoSHA=; b=MiZAVp/lF6YcK1M4WaaW6tD91Ay1mHDeGgf0/zsQH5ckJwEmKwIkEMHXSZLBu6nZ0he7fi TrUnOlunFg7TCQ9eaKGhv61p6twE7fZ17XYC8k99f50LdD1zumkpVFesaOrmnYljO32+0o QFCLjws5zZwrMdCQeWypeSAdD33covE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-589-exaZVa4bOLCgv7JyROiQHQ-1; Mon, 21 Mar 2022 07:41:30 -0400 X-MC-Unique: exaZVa4bOLCgv7JyROiQHQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 847DD802809; Mon, 21 Mar 2022 11:41:29 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5028B40C1247; Mon, 21 Mar 2022 11:41:28 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <0000000000003c424505daaed1b7@google.com> References: <0000000000003c424505daaed1b7@google.com> To: syzbot Cc: dhowells@redhat.com, jarkko@kernel.org, jmorris@namei.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, serge@hallyn.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] memory leak in keyctl_watch_key MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1019066.1647862887.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Mon, 21 Mar 2022 11:41:27 +0000 Message-ID: <1019067.1647862887@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org free_watch() is missing a kfree() to actually free the watch. #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs= .git c82efd1dfb229d6aa7e08d57d1c41f034d97b1eb