From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751964AbdJLP1D (ORCPT ); Thu, 12 Oct 2017 11:27:03 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:22370 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751453AbdJLP1B (ORCPT ); Thu, 12 Oct 2017 11:27:01 -0400 X-AuditID: b6c32a45-d23ff70000001088-24-59df89c2c772 From: Bartlomiej Zolnierkiewicz To: Colin King Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/video/fbdev/atyfb: make const arrays static, reduces object code size Date: Thu, 12 Oct 2017 17:26:56 +0200 Message-id: <10191317.Qqof1SveHP@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170913150309.6250-1-colin.king@canonical.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsWy7bCmme6hzvuRBl/eWFn8Xt3LZnHl63s2 ixN9H1gtLu+aw+bA4jGroZfN4373cSaPz5vkApijuGxSUnMyy1KL9O0SuDK+nNrFXHCRrWJV cyNjA+M3li5GTg4JAROJW/fvAdlcHEICOxgllq6axQzhfGeUeDlhKyNM1fH1P9lBbCGBDYwS Mzt0IIq+Mkq0vj4CVsQmYCUxsX0VkM3BISKgKXH+XBFImFkgQeLLzc/MIGFhgRSJM4+TQMIs AqoScw9cBzuCV0BL4kHzLbApogJeElv2tTOB2JwCthLr7t2GqhGU+DH5HgvESHmJffunskLY OhJnj61jBDlHQmAGm8TavcfYIW52kdh1cA8rhC0s8er4Fqi4tMSzVRuh/prOKLH9twRE82ZG iVW7J0AVWUscPn4RagOfRMfhv+wgD0gI8Ep0tAlBlHhIbN07nQnCdpTY3/qfHRImExglHrcv ZJ/AKDsLyeGzkBw+C8nhCxiZVzGKpRYU56anFhsVGOoVJ+YWl+al6yXn525iBEe8lusOxhnn fA4xCnAwKvHw7ii/HynEmlhWXJl7iFGCg1lJhNcDmC6EeFMSK6tSi/Lji0pzUosPMUpzsCiJ 89ZvuxYhJJCeWJKanZpakFoEk2Xi4JRqYPRbFrL6if4FhzOBS6PMPFfPafPOe7v6YMS7G3NX nFq/kf/F9ZXmNx6uDV58YdHN1zulhHSuxUVPP5vxfeOuq6c8t1+YmG4sukHix6qS3jm5q32/ HU989XnJxpKZa2o442sm/+84KfpbQXn/3Bu3GtdXChd6XPjx8JBFy89ZKUcjD7owz5rTsUNL UomlOCPRUIu5qDgRAILfZ4P0AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFLMWRmVeSWpSXmKPExsVy+t9jQd1DnfcjDY5uVrH4vbqXzeLK1/ds Fif6PrBaXN41h82BxWNWQy+bx/3u40wenzfJBTBHcdmkpOZklqUW6dslcGV8ObWLueAiW8Wq 5kbGBsZvLF2MnBwSAiYSx9f/ZO9i5OIQEljHKHH52TRmCOcro8TXnUeZQKrYBKwkJravYuxi 5OAQEdCUOH+uCCTMLJAgsen+VDaQsLBAisSZx0kgYRYBVYm5B66DzecV0JJ40HyLEcQWFfCS 2LKvHWwip4CtxLp7t1kgVk1ilGj9cIQZokFQ4sfkeywQ8+Ul9u2fygpha0ms33mcaQIj/ywk ZbOQlM1CUraAkXkVo2RqQXFuem6xUYFRXmq5XnFibnFpXrpecn7uJkZgiG47rNW/g/HxkvhD jAIcjEo8vDvK70cKsSaWFVfmHmKU4GBWEuH1AAa4EG9KYmVValF+fFFpTmrxIUZpDhYlcV7+ /GORQgLpiSWp2ampBalFMFkmDk6pBsYzXws+bisuWFkXe+60DAs3j6nFv/qnbuLGfDLFf6sf XTj9YZaZRXpJAM+i15JczyQTjZj5OhdFfvjHtPikphzL9uYJb7Ub1Fr69ygdWrKiaZfClo5N Ypt1+X86a3RIpL34+9B3TXSL5RPWwNjTYndzOnMbF2mG1QWd/f9no4Xh7x9qYWfZE5RYijMS DbWYi4oTAcWsIFxNAgAA X-CMS-MailID: 20171012152658epcas2p43607940b4e022876b02c40f30b1814d2 X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 102P X-CMS-RootMailID: 20170913150314epcas1p4257193707b94242110eb6b9b7a9fdd4b X-RootMTR: 20170913150314epcas1p4257193707b94242110eb6b9b7a9fdd4b References: <20170913150309.6250-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 13, 2017 04:03:09 PM Colin King wrote: > From: Colin Ian King > > Don't populate the const arrays ragepro_tbl and ragexl_tbl on the stack, > instead make them static. Makes the object code smaller by over 380 bytes: > > Before: > text data bss dec hex filename > 41089 10592 768 52449 cce1 atyfb_base.o > > After: > text data bss dec hex filename > 40544 10752 768 52064 cb60 atyfb_base.o > > (gcc version 7.2.0, x86_64) > > Signed-off-by: Colin Ian King Patch queued for 4.15 (with patch description fixed to "video: fbdev: aty: ..." for consistency with other patches), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics