From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F60D382374 for ; Wed, 25 Mar 2026 10:00:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774432858; cv=none; b=C3mJjN3Rop/TyBYc2k9MJyrK0fyzTZpMyGzT2sNWT208eFYEYRtgEP7WTi5QxwMzA/+54td10RE/BkGbh6l822ZCrSIQ27wRKQLLxP51z3OoBSHBogtub90tTNDD76E4sQXFxZI5glQVTSPpuYW85goeB3tADzEtPfwTMuCB40A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774432858; c=relaxed/simple; bh=oDl7hVNCNw1wViKVC93Xs6nypWvwx2yPpYHa0agOIKw=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=mJy79VM6tB/FkcUm/hBil59TeYvScXBDBuH09cVN0X/3jg0Ysu5Qe75q7aBxdWnS7nsM6ifxsgObhg5+d2z1qqrCxvjz7oq03Wsg3vMVwce9Hof07TQerNcARZJjKnZNkWWAZZUYHspVz65I7szTSRfOs6Xtxx5nggIx0Kum1Us= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iTz5gDCt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=POPfHCcK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iTz5gDCt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="POPfHCcK" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62P5TvgT1862315 for ; Wed, 25 Mar 2026 10:00:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wUAfXeafFBwWr30Ieze/5KFQiGM9ADTdz912cIXW+7w=; b=iTz5gDCtgzwvyrhO fCItJzkDkhdWjdZ5FcpNCD5mQoQQHMFKnmoiQNLH4XnsJL40miAZWKm/iP+cxORl HQj7eajfp2+6jAQ77jFPSJyf8UfEFPWjU1GwZBw/tVtveKAot0d93vz95RL09LjJ G0XbiCN2MeQkbfq4fB/L+xuuqTUrtwRfU+LoNk5HCw5J3BfXqG1lw76Xoxmlj/wD ct9CQUZK0jghoBbVmONSUQr9jelCErkLW4tpiTLhKOYC0OyFh4O7NjfF1+mIwA9/ ruCmG0zBpBiNTnXTjkoRX+bpsai6D0C8N37sD9vbXh6Nxbtb7WXp3R3RdBAUZ4Ti YaT6+g== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d40ratj3j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Mar 2026 10:00:54 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-5ffeafd52e3so355223137.3 for ; Wed, 25 Mar 2026 03:00:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774432854; x=1775037654; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=wUAfXeafFBwWr30Ieze/5KFQiGM9ADTdz912cIXW+7w=; b=POPfHCcK4D9BqkBc9wmq3YevoX5QMsXeCeTbAlGASS/xzH1KG2stbtztvs3Cl8Mf+C jwYHAEsuv1p+0o0+H+KlgVpS4YLBvmD+F9Jf86ME4WLrT3hFpNoM1H9UTCdlPxp25kfE 4Y6BjDGdGwENlvORnl20IN9bwgkbbe5g5A8ZsE+53Ui7d3M4UTCUkXxg2QXO1oCSKG7N SeCAlL0BZOVSQzycM+lcTbsR4bq/A99VQOkuar87GJS/XdGCY1vOl9poSlITXxVEQtFs KEFDSI6QePw7K/l3/uUzGm5o90l3lxJ9V8sa3jJ7TR0bf9CY+wa79ZGf/EWRAlBZOXCk A2yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774432854; x=1775037654; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wUAfXeafFBwWr30Ieze/5KFQiGM9ADTdz912cIXW+7w=; b=KlfWWqahLN55PYnpNHeDaYP7XTacqf0zXL9AMME0Slei9lWCveyCVV+XvQ95zpapkB UMEeYOGyDMcrFLxTDTlIRF7tFRaWBgWVxl2xrFSI4SKRNUWhNcs7i2bwOKUMCbeA+A4b bSrZw1NXekTb54rs3jQA50SU0QlLbHuA3SNV8wYH2vFFmdbATjirPsJ3RLNI6ZHfXEad oizU91cBfm2hUJOGbue6+e8Lde/dVQqjR9nLzse43rZ91GHiPG4luPQqRRGIzGptE9yJ O2MkoIxaWau9MG4S8RCWuFlanvTyyAIGHsGWhaBoKk/VpZA5MG2xaCotmXRXj2YeaEeE FXQw== X-Forwarded-Encrypted: i=1; AJvYcCU13ouVOAq7xUfm7eS5LpKEiQdO8uYwF/ed8l/PPcuDSIi9nXGzX4ZFbvxYG2U5Su75TF/XwafPfpGIowg=@vger.kernel.org X-Gm-Message-State: AOJu0YxJWEIk1D2AnNbug5VOqjjx78qP38qf1t/BNj8ulLz8BEZ7xTDE lptXRlkWKriVcCTgsbvbK9n4uODwxaSFpLIvdS4yHlNXOD0Y//kVEWPdjo00cT2kZ8/mMjbzhU+ yjqvdt29h2VcnBGp/FpsiDtRKlwSEX73n60wHrzg2QGgQd5UlXoA160L6HmXNU/p5GFw= X-Gm-Gg: ATEYQzwD4seN7Y9q9rnrYo3z3Z7HgG7fMXS4+erWtSPTdIlMRfrkX8NWnbl8XVtKakv 8aq4M37tnEi3F9jay/cHynz+oL++QijOKumvEXcelsQLIbkAqO8JbmdClmFg21vSPbssS7HTIRg DkcVblotSAJ2JiEAhUNLGDs0eErfsRbNbMkjtSRL1nc4J3vEXXQCij512vjJqW3XR5y6JKnq8I5 lpRUvnDu1kN7r+i4Zumj9cjhb0UwixNqN6VxNWwtWVcZjzPI1K5c1PcMGQh6T0U4db9gmz/zfNa wD0Uwtj9kIS08ixjisf3iAsJeXjTPignzrE2FyNeKH2I3MjwtDFCulIxE4hDVoVZ3DdDgr7wqya Qk/VSzxtlITnMBGU4xo/C0KhArc1g4wPMQbJ+oJwMQ+51zFlLYvLhHDu3Fq6lIY6EvKdKEAYMd/ Zme54= X-Received: by 2002:a67:e885:0:b0:602:8a0e:f872 with SMTP id ada2fe7eead31-6038732bfc7mr487709137.8.1774432854111; Wed, 25 Mar 2026 03:00:54 -0700 (PDT) X-Received: by 2002:a67:e885:0:b0:602:8a0e:f872 with SMTP id ada2fe7eead31-6038732bfc7mr487685137.8.1774432853359; Wed, 25 Mar 2026 03:00:53 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b98335de1e3sm772362166b.39.2026.03.25.03.00.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 03:00:51 -0700 (PDT) Message-ID: <101aae08-efde-4d9d-8af2-613d4cc9698a@oss.qualcomm.com> Date: Wed, 25 Mar 2026 11:00:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/dpu: correct DP MST interface configuration From: Konrad Dybcio To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Luca Weiss , Alexander Koskovich Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar , Yongxing Mou References: <20260325-fix-dp-mst-interfaces-v1-1-186d1de3fa1b@oss.qualcomm.com> <3f33e61e-d244-4600-9ffe-218371c04541@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <3f33e61e-d244-4600-9ffe-218371c04541@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Jvr8bc4C c=1 sm=1 tr=0 ts=69c3b256 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=gZczchgc3zH-k75L218A:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: MGe76KQfA-R17GoWV91vuhE8txyOfg1c X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDA3MSBTYWx0ZWRfX8DGQGHx7o2GD YfziDWYOfFiEcDa3ag7toRI5R7ruywqdrhO20TG8m4g+1WDQNm38t5xfNORSfM67qo+AIKvTmQJ okF/3F06nNGfQn1u0B/84R59C5hjgGgdAIX4bnXXXjl2jq7PcTWEXuXLDtsrQ/wBelXBhR+QEHG yUar5wej/TkzYh3kHP7e3mFGVDMlcE4MwdO5ZFNjNzcGPZAIxCHhspgdqbXZ6pS8zZDWiL55L9D 5iKmUmp5Mo1xNLbsjH1Fw/van3M+Rh+HTy455HbyETc+4u8CwOVdihT/w6TyillI/lBfo0MUSVO pM/qiGicpRqa+pLnSiiMrG4Az8isxgO91aPBb7gcANuVmPgHj5K574NnB2qDE7kLA2axUW8F7z+ zz1QmnJrg6fpz6JFr1qO9zqbHd0eljpBiMGMPlNshxtQ5S5048SOmLp2LPi49Jkok3hPF2B8oZm xE9RgDKRxDWtGwtZTTg== X-Proofpoint-GUID: MGe76KQfA-R17GoWV91vuhE8txyOfg1c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-25_03,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 phishscore=0 priorityscore=1501 spamscore=0 clxscore=1015 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250071 On 3/25/26 10:57 AM, Konrad Dybcio wrote: > On 3/25/26 6:32 AM, Dmitry Baryshkov wrote: >> Due to historical reasons we ended up with dummy values being specified >> for MST-related interfaces some of them had INTF_NONE, others had >> non-existing DP controller indices. Those workarounds are no longer >> necessary. Fix types and indices for all DP-MST related INTF instances. >> >> The only exception is INTF_3 on SC8180X, which has unique design. It can >> be used either with INTF_0 / DP0 or with INTF_4 / DP1. This interface is >> left with the dummy value until somebody implements necessary bits for >> that platform. >> >> Co-developed-by: Abhinav Kumar >> Signed-off-by: Abhinav Kumar >> Signed-off-by: Yongxing Mou >> Signed-off-by: Dmitry Baryshkov >> --- > >> .name = "intf_8", .id = INTF_8, >> .base = 0x3c000, .len = 0x280, >> - .type = INTF_NONE, >> - .controller_id = MSM_DP_CONTROLLER_1, >> + .type = INTF_DP, >> + .controller_id = MSM_DP_CONTROLLER_1, /* pair with intf_8 for DP MST */ > > with intf_4 Otherwise this is all correct Reviewed-by: Konrad Dybcio Luca/Alexander, Milos will also have INTF0+INTF_3 paired Konrad