From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 847EB13B7A3 for ; Sat, 13 Dec 2025 03:33:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765596802; cv=none; b=QIgpXTXvT9Vl5N5L8na/WYZlK2k9q0HCb+DGi30nHPVZ2xVSG4Z1xv51elKibUN3n3ZBlDFE7Br+GSdbO8Emve2lbonVwxhuvyq/n7cYoFxGtQNl64YUa25wWFXjLowHmuXevVXRw3dHAO33+HO/0bbhh52GE79n4DwJumcACkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765596802; c=relaxed/simple; bh=BRZKiTHuhL4ZhrdTpO8xXNl40QEVVOTMX0hODcKWT2I=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=WizE/LUySUw7+wu5wS8N4BTup6c+4yjCWD5spaCnv/AK7F0MnNmNVhD1q4m79ab5jvN9AhpgJrmhZMj/c82fDIERLu9xzGKO3RKn8SfQogw9lFNtUHbcSKCJrkNdK2qXs3DbuSbc1Wd0diJ2EOl18ATpnyKWD9De9761aaOa9M4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a+ZA2B4e; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a+ZA2B4e" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2a099233e8dso663795ad.3 for ; Fri, 12 Dec 2025 19:33:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765596800; x=1766201600; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=RVirYJs36pEisWr0xabkqAapKQWYDBIRC38oiXekHdM=; b=a+ZA2B4efFVLHyesBvJ7WlT+qJsTFiYut+1b7j/Vht1y7CDyj6aKnR+REG5hdFjx1V fNy9tqYQ+8AS6Mix1Yz7grqSbtW1KHwibO8OnOl0tPni1LFtVeNjAlRG78BmwQFl2qij d/cb9SeDmDQWwngVf5uhEf/Cv0P5eUYha99zNPoajdU88vGO+6dpda3vhoB0pI/RREVS 7X4MZoIX/VD5539fe5N6SH0iVHYprdCUrMNVDouBN1EylpoMhYBw4WjeD46Jzn+9iDDl 6aZpdhU+tqDRm1YmgOspY2KFmZn3zBWUMLSYPF4u0l3kZKqi6uV4ATRXbBxIzEVqtcIX 7i4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765596800; x=1766201600; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RVirYJs36pEisWr0xabkqAapKQWYDBIRC38oiXekHdM=; b=GOiaoM8R8IhfkSkMQEeuxuq7XjrNa45BMYWM3FbAVEl9it6n2NYSwPh+63SH4rHJAk f/aNjhz7LpyGv7gnVMRBBW4agGj8NdyuTFAGA+5XCsoh5NGjOgMk7hExA0Wr0dR48opi LjTZoqe0U8DvKkMRvbUDArGUlMnOVCTGuG1OAhnNI8aKPRyRl4r9+TntI208jqoFUStZ +UWh1lqAw/UWI8cPL6MtCh0tjZMs4bEGvniPdDb5S5JDutV++b7WSpyHhcSPr1P3q/FL WvAOnOvCjou7TZWgb+bQuH0OmFcQ1ZYiTfvwCSrzMZP3vN2QxQNORyDNv3dAFSufUrMO sGiQ== X-Gm-Message-State: AOJu0YzKlGSzyQJB3SQHBjOurn+G2RlpWFSFew9l0irudnZjabKu4Wbx ukNDEbdkRBL0q+VArXiXgvmV+ujqhUH2QrINBomnSv1pC93JT8CPXarO X-Gm-Gg: AY/fxX6hAJmlwEWOxQBUEWT2Qg0MpAMRMqVrauSeWVL8HXeGe+tjK95KVIR7eKM5ynq /qE8U4jMj8nVFAqP9wbYOBSXge/LDgF4nL9ofvKQgQCb9ehJYzBaOJsjSuvYOm3/+U1tLjFPtyw itPVumYnTsUAMr07UHDe9whIAppGqS77CFpjBF6ZYKAzF/uxGyDSGpKurp2FBwnJTmS/SvsGbfN 4m5HVc9e1UYDlHbYPq8rFog2qJlubN2DM3s8ChLQOBY8VgBZidQa5LSd4BmizfrYGPQRcpjx9if hpM9F51k4c5HwRVnjUHrUR71gkrX5LO74ohsfge5qZCPqS/C4YWWVzuDtxxTpMi2IdmgwaVPtKC fCzJsEaWkbfuTcUwbcCty2QS4VrGer4cKIxm+bXowrEFjop8BH14CzobIYS3MSTqNG4G2VzByZf OEZuFidCmvxjqcWWrCQe1c7SO2ialr/PUD5ZL6RH/O9X1Gm01RQK2D6CCGqA== X-Google-Smtp-Source: AGHT+IH6Au00sYNWU8Mi5YUTwgkiE8WaJV919Fm+0jkmxXzOjLssbO+WP7Caj1TQxwhH44sOyNCD6w== X-Received: by 2002:a17:903:2f45:b0:299:fc47:d7e3 with SMTP id d9443c01a7336-29f2403aef7mr45500585ad.31.1765596799733; Fri, 12 Dec 2025 19:33:19 -0800 (PST) Received: from [10.200.4.113] (p99249-ipoefx.ipoe.ocn.ne.jp. [153.246.134.248]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29efd74f5e1sm51961605ad.16.2025.12.12.19.33.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Dec 2025 19:33:19 -0800 (PST) Message-ID: <101bb8011cc6be8e60409d294c8c0abe93b9ed72.camel@gmail.com> Subject: Re: [PATCH v4 4/4] nvme: Allow reauth from sysfs From: Wilfred Mallawa To: alistair23@gmail.com, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, hare@suse.de, kch@nvidia.com, linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Alistair Francis Date: Sat, 13 Dec 2025 12:33:16 +0900 In-Reply-To: <20251202051755.1312158-5-alistair.francis@wdc.com> References: <20251202051755.1312158-1-alistair.francis@wdc.com> <20251202051755.1312158-5-alistair.francis@wdc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2025-12-02 at 15:17 +1000, alistair23@gmail.com wrote: > From: Alistair Francis >=20 > Allow userspace to trigger a reauth (REPLACETLSPSK) from sysfs. > This can be done by writing=C2=A0 a zero to the sysfs file. >=20 > echo 0 > /sys/devices/virtual/nvme- > fabrics/ctl/nvme0/tls_configured_key >=20 > In order to use the new keys for the admin queue we call controller > reset. This isn't ideal, but I can't find a simpler way to reset the > admin queue TLS connection. >=20 > Signed-off-by: Alistair Francis > --- > v4: > =C2=A0- Forcefully reset the connection > v3: > =C2=A0- Only trigger if a 0 is written to `tls_configured_key` > =C2=A0- Add documentation > v2: > =C2=A0- Trigger on any value written to `tls_configured_key` >=20 > =C2=A0Documentation/ABI/testing/sysfs-nvme | 13 ++++++++ > =C2=A0drivers/nvme/host/sysfs.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 | 44 > +++++++++++++++++++++++++++- > =C2=A02 files changed, 56 insertions(+), 1 deletion(-) > =C2=A0create mode 100644 Documentation/ABI/testing/sysfs-nvme >=20 > diff --git a/Documentation/ABI/testing/sysfs-nvme > b/Documentation/ABI/testing/sysfs-nvme > new file mode 100644 > index 000000000000..16aaf0dca9e2 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-nvme > @@ -0,0 +1,13 @@ > +What: /sys/devices/virtual/nvme- > fabrics/ctl/.../tls_configured_key > +Date: November 2025 > +KernelVersion: 6.19 > +Contact: Linux NVMe mailing list > > +Description: > + The file is avaliable when using a secure > concatanation > + connection to a NVMe taget. Reading the file will > returns s/a NVMe taget/an NVMe target s/returns/return Otherwise LGTM Reviewed-by: Wilfred Mallawa Wilfred