mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Shreeya Patel <shreeya.patel@collabora.com>,
	Zhigang Shi <Zhigang.Shi@liteon.com>,
	Paul Gazzillo <paul@pgazz.com>,
	Dmitry Osipenko <dmitry.osipenko@collabora.com>,
	Liam Beguin <liambeguin@gmail.com>, Peter Rosin <peda@axentia.se>,
	Randy Dunlap <rdunlap@infradead.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/6] dt-bindings: iio: light: Support ROHM BU27034
Date: Thu, 23 Feb 2023 06:20:16 +0000	[thread overview]
Message-ID: <101db5e2-e878-b751-9679-6ea45eb24c26@fi.rohmeurope.com> (raw)
In-Reply-To: <e6b2a6f4-d710-7f74-e85d-1cd3f5b96460@linaro.org>

Hi dee Ho Krzysztof,

Thanks for the review! It's nice you had the time to take a look on RFC :)

On 2/22/23 20:57, Krzysztof Kozlowski wrote:
> On 22/02/2023 17:14, Matti Vaittinen wrote:
>> ROHM BU27034 is an ambient light sesnor with 3 channels and 3 photo diodes
>> capable of detecting a very wide range of illuminance. Typical application
>> is adjusting LCD and backlight power of TVs and mobile phones.
>>
>> Add initial dt-bindings.
> 
> Driver can be "initial", but bindings better to be closer to complete,
> even if not used by the driver currently.

Out of the curiosity - why is that? (Please, don't take me wrong, I am 
not trying to argue against this - just learn the reason behind). I 
can't immediately see the harm caused by adding new properties later 
when we learn more of hardware. (and no, I don't expect this simple IC 
to gain at least many properties).

>> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
>> ---
>>   .../bindings/iio/light/rohm-bu27034.yaml      | 46 +++++++++++++++++++
>>   1 file changed, 46 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/iio/light/rohm-bu27034.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/rohm-bu27034.yaml b/Documentation/devicetree/bindings/iio/light/rohm-bu27034.yaml
>> new file mode 100644
>> index 000000000000..a3a642c259e8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/light/rohm-bu27034.yaml
> 
> 
> Comma as a separator, so:
> rohm,bu27034.yaml

Oh, yes. So it seems.

Strange, I could have sworn I used hyphen in binding file names 
previously although the comma has been used in the compatible. I had to 
go back in time (lore,kernel.org) to check my earlier submissions. Well, 
my mind seems to be playing tricks on me @_@. I'll fix this before 
sending out non RFC series :)

Good catch (as always)! Thanks!

>> @@ -0,0 +1,46 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/iio/light/rohm-bu27034.yaml#
> 
> With filename and $id fix:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> 
> Best regards,
> Krzysztof
> 

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~


  reply	other threads:[~2023-02-23  6:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-22 16:13 [RFC PATCH 0/6] Support ROHM BU27034 ALS sensor Matti Vaittinen
2023-02-22 16:14 ` [RFC PATCH 1/6] dt-bindings: iio: light: Support ROHM BU27034 Matti Vaittinen
2023-02-22 18:57   ` Krzysztof Kozlowski
2023-02-23  6:20     ` Vaittinen, Matti [this message]
2023-02-23  9:26       ` Krzysztof Kozlowski
2023-02-23 10:59         ` Matti Vaittinen
2023-02-26 13:39         ` Jonathan Cameron
2023-02-22 16:14 ` [RFC PATCH 2/6] iio: light: Add gain-time-scale helpers Matti Vaittinen
2023-02-26 16:21   ` Jonathan Cameron
2023-02-28  9:09     ` Vaittinen, Matti
2023-02-28 11:13     ` Vaittinen, Matti
2023-02-22 16:15 ` [RFC PATCH 3/6] iio: test: test " Matti Vaittinen
2023-02-22 16:15 ` [RFC PATCH 4/6] MAINTAINERS: Add IIO " Matti Vaittinen
2023-02-22 16:15 ` [RFC PATCH 5/6] iio: light: ROHM BU27034 Ambient Light Sensor Matti Vaittinen
2023-02-24 10:41   ` Matti Vaittinen
2023-02-26 13:52     ` Jonathan Cameron
2023-02-28  8:43       ` Vaittinen, Matti
2023-03-04 18:53         ` Jonathan Cameron
2023-02-26 17:13   ` Jonathan Cameron
2023-03-02  7:35     ` Vaittinen, Matti
2023-03-04 19:11       ` Jonathan Cameron
2023-02-22 16:16 ` [RFC PATCH 6/6] MAINTAINERS: Add ROHM BU27034 Matti Vaittinen
2023-02-26 13:42   ` Jonathan Cameron
2023-02-27  5:51     ` Matti Vaittinen
2023-02-26 16:28 ` [RFC PATCH 0/6] Support ROHM BU27034 ALS sensor Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=101db5e2-e878-b751-9679-6ea45eb24c26@fi.rohmeurope.com \
    --to=matti.vaittinen@fi.rohmeurope.com \
    --cc=Zhigang.Shi@liteon.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.osipenko@collabora.com \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lars@metafoo.de \
    --cc=liambeguin@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=paul@pgazz.com \
    --cc=peda@axentia.se \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=shreeya.patel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®