From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rong Qianfeng <rongqianfeng@vivo.com>,
Yong Wu <yong.wu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: opensource.kernel@vivo.com
Subject: Re: [PATCH] memory: mtk-smi: Simplify using devm_clk_get_enabled()
Date: Tue, 20 Aug 2024 14:40:21 +0200 [thread overview]
Message-ID: <101f33d8-9bb9-4722-9a6a-718394246b70@kernel.org> (raw)
In-Reply-To: <20240820123426.48694-1-rongqianfeng@vivo.com>
On 20/08/2024 14:34, Rong Qianfeng wrote:
> devm_clk_get_enabled() will call devm_clk_get() + clk_prepare_enable()
> and the clock will automatically be disabled, unprepared and freed when
> the device is unbound from the bus.
That's obvious, drop. You do not have to explain basic APIs. Instead say
what is being simplified here.
> So simplify mtk_smi_common_probe()
> accordingly.
Also explain that you fix bug of missing unprepare in unbind and add
Fixes+CC stable tags.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-20 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 12:34 Rong Qianfeng
2024-08-20 12:40 ` Krzysztof Kozlowski [this message]
2024-08-21 2:02 ` Rong Qianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=101f33d8-9bb9-4722-9a6a-718394246b70@kernel.org \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=opensource.kernel@vivo.com \
--cc=rongqianfeng@vivo.com \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®