mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Tom 'spot' Callaway" <tcallawa@redhat.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Fix scsi.c kmod noise
Date: 09 May 2002 13:36:52 -0400	[thread overview]
Message-ID: <1020965812.1777.9.camel@zorak.rdu.redhat.com> (raw)

This patch fixes the scsi kmod issue that annoyed me to tears, and
confused me on several bug reports. This error crops up whenever scsi.c
is compiled in (which is fairly common in 2.4, Red Hat Linux does this
as well). Since its in scsi.c, this bug occurs on all archs, not just
sparc/sparc64 (which is where I'm working).

"kmod: failed to exec /sbin/modprobe -s -k scsi_hostadapter, errno = 2"

I didn't see it in bk, so I sent it here.

~spot
---
Tom "spot" Callaway <tcallawa@redhat.com> Red Hat Sales Engineer
Sair Linux and GNU Certified Administrator (LCA)
Red Hat Certified Engineer (RHCE)
GPG: D786 8B22 D9DB 1F8B 4AB7  448E 3C5E 99AD 9305 4260

The words and opinions reflected in this message do not necessarily
reflect those of my employer, Red Hat, and belong solely to me.

"Immature poets borrow, mature poets steal." --- T. S. Eliot
----


--- linux/drivers/scsi/scsi.c.OLD	Wed May  1 16:33:14 2002
+++ linux/drivers/scsi/scsi.c	Wed May  1 16:34:46 2002
@@ -2389,10 +2389,18 @@
 
 		/* Load upper level device handler of some kind */
 	case MODULE_SCSI_DEV:
+
+/* This doesn't make much sense to do unless CONFIG_SCSI is a module itself.
+ *
+ * ~spot <tcallawa@redhat.com> 05012002
+ */
+
+#ifdef MODULE
 #ifdef CONFIG_KMOD
 		if (scsi_hosts == NULL)
 			request_module("scsi_hostadapter");
 #endif
+#endif
 		return scsi_register_device_module((struct Scsi_Device_Template *) ptr);
 		/* The rest of these are not yet implemented */
 


             reply	other threads:[~2002-05-09 17:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-09 17:36 Tom 'spot' Callaway [this message]
     [not found] <mailman.1020966481.25371.linux-kernel2news@redhat.com>
2002-05-09 20:33 ` Pete Zaitcev
2002-05-09 20:41   ` Doug Ledford
2002-05-09 22:41     ` Tom 'spot' Callaway
2002-05-09 23:55       ` Christoph Hellwig
2002-05-10  0:46       ` Patrick Mansfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1020965812.1777.9.camel@zorak.rdu.redhat.com \
    --to=tcallawa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®