mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Timur Tabi <ttabi@nvidia.com>, "dakr@kernel.org" <dakr@kernel.org>
Cc: "gary@garyguo.net" <gary@garyguo.net>,
	Shashank Sharma <shashanks@nvidia.com>,
	"lossin@kernel.org" <lossin@kernel.org>,
	"boqun.feng@gmail.com" <boqun.feng@gmail.com>,
	"a.hindborg@kernel.org" <a.hindborg@kernel.org>,
	Zhi Wang <zhiw@nvidia.com>, "simona@ffwll.ch" <simona@ffwll.ch>,
	"alex.gaynor@gmail.com" <alex.gaynor@gmail.com>,
	"ojeda@kernel.org" <ojeda@kernel.org>,
	"nova-gpu@lists.linux.dev" <nova-gpu@lists.linux.dev>,
	"tmgross@umich.edu" <tmgross@umich.edu>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bjorn3_gh@protonmail.com" <bjorn3_gh@protonmail.com>,
	Eliot Courtney <ecourtney@nvidia.com>,
	"airlied@gmail.com" <airlied@gmail.com>,
	"aliceryhl@google.com" <aliceryhl@google.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	Alexandre Courbot <acourbot@nvidia.com>,
	Alistair Popple <apopple@nvidia.com>
Subject: Re: [PATCH] gpu: nova-core: don't declare booter firmware for FSP chipsets
Date: Wed, 10 Jun 2026 16:23:11 -0700	[thread overview]
Message-ID: <1022c9e9-7d90-498a-b420-64b945f93c74@nvidia.com> (raw)
In-Reply-To: <2ccadf609a4bcb9b4aad5ec6b6998fc352dc2f12.camel@nvidia.com>

On 6/8/26 5:00 PM, Timur Tabi wrote:
> On Tue, 2026-06-09 at 00:57 +0200, Danilo Krummrich wrote:
>>> +        // FSP-based chipsets (Hopper and later) boot the GSP via the FMC image
>>> +        // loaded by FSP. Older chipsets use the SEC2 booter instead.
>>
>> NIT: This is slightly ambiguous, since despite technically being the same
>> generation, by architecture ID Ada numerically sits in between Hopper and
>> Blackwell, but does not use FSP.
> 
> Maybe we should add a comment to the define_chipset! block in gpu.rs which clarifies that even
> though GH100 has a lower chipid then AD102, we consider Hopper to be a newer architecture than Ada.

Yes. I'll send a tiny follow-up patch for these points.

thanks,
-- 
John Hubbard


  reply	other threads:[~2026-06-10 23:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-07 23:05 John Hubbard
2026-06-08 22:09 ` Timur Tabi
2026-06-08 22:57 ` Danilo Krummrich
2026-06-09  0:00   ` Timur Tabi
2026-06-10 23:23     ` John Hubbard [this message]
2026-06-09  6:06 ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1022c9e9-7d90-498a-b420-64b945f93c74@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=ecourtney@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=nova-gpu@lists.linux.dev \
    --cc=ojeda@kernel.org \
    --cc=shashanks@nvidia.com \
    --cc=simona@ffwll.ch \
    --cc=tmgross@umich.edu \
    --cc=ttabi@nvidia.com \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®