From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C56EC10F19 for ; Tue, 15 Aug 2023 20:38:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238769AbjHOUhz (ORCPT ); Tue, 15 Aug 2023 16:37:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238399AbjHOUhV (ORCPT ); Tue, 15 Aug 2023 16:37:21 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1BFC1BFF for ; Tue, 15 Aug 2023 13:36:46 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-99bc9e3cbf1so1208112766b.0 for ; Tue, 15 Aug 2023 13:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692131802; x=1692736602; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X6Sjc5kCdevNBIooFIAdaXcgvp9MHaLBrm4GmR4a5kI=; b=fAj5Uun6fMmg8JwRtrO+awU+LcEYYn3b1AiRgb2/esrYZBkNM8tV10/hR44o06tYxe x6tW13BtvxlFQHUYSqCIZV5Ry835ARs2CNw903bBXAvZ+OehESNUGsUEsnaUYN1sTHdq shby10LOk+9SulpTwmNO7xf04GJoS2R8Ey3J9g6DxAo6+MKv19y5GR/Dmo7R97yAG+mL F5k2GyoQ+ROmnqMzBPGvHOv7I5DwPEr+mJOC2jM2/HNe2rq9pxwgYcUGWrCIAJMvNhAe dJ5rKDHjV9bKla4CBC1ge739eOZnuCIEhDBfWTLKGMk5tOMBE2eYhAYPy7bzn2RJ5Siw +gfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692131802; x=1692736602; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X6Sjc5kCdevNBIooFIAdaXcgvp9MHaLBrm4GmR4a5kI=; b=Xk0IxiYHBl+EYAB5YXzx4xnmOnBWYwq2RNy7IhGQr0ka+P2+TPqbVCFfnjOCagYoJe 2C8q18mzplP8ycCyIbmj5TSsRqbV85J8jKc/URAzvEdi7dQRsBlAnBMgLO1sPb5rFVsl GTeaawNQsmENRmlNhB6WfDf0IYIVTP/39TWEHNGBGWe/MulrzCUNcYI07XRU2dUyUsJx zoMZjRJ8PAeBWDCWvyicS7ZQzZqt/Fj9csyM6Zr91gCZIEMP0npdh18qymtkpUz5s25c xTBmi7GxpswLz6GNRfIIP83uXZ2HpeD9plSkv4nfD9jtEMkH5yoFue8swT8O5O21219+ wjAA== X-Gm-Message-State: AOJu0YzvoNcH2UR0m95fBDIvXfX5q7GzmdOP5TbImxkSAZ2R0d5noWE9 cw2jtdK4nR8qrkVT2aAaLbkL5A== X-Google-Smtp-Source: AGHT+IH4wM7nrkfOFTqG/v7+FSAdJxm80o8iaJuv9GJHnk6yEmOMGbDxs3H4ETByecHIE/WMvpi9VA== X-Received: by 2002:a17:906:6a04:b0:99b:dd23:4f01 with SMTP id qw4-20020a1709066a0400b0099bdd234f01mr3314224ejc.33.1692131802432; Tue, 15 Aug 2023 13:36:42 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id f8-20020a17090624c800b009894b476310sm7407880ejb.163.2023.08.15.13.36.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 13:36:42 -0700 (PDT) Message-ID: <102328fa-5699-4731-d639-079bce8863a5@linaro.org> Date: Tue, 15 Aug 2023 22:36:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 1/7] dt-bindings: soc: qcom: Add qcom,pbs bindings Content-Language: en-US To: Anjelique Melendez , pavel@ucw.cz, lee@kernel.org, thierry.reding@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org Cc: luca.weiss@fairphone.com, konrad.dybcio@linaro.org, u.kleine-koenig@pengutronix.de, quic_subbaram@quicinc.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org References: <20230814235918.10396-1-quic_amelende@quicinc.com> <20230814235918.10396-2-quic_amelende@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230814235918.10396-2-quic_amelende@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/08/2023 01:59, Anjelique Melendez wrote: > Add binding for the Qualcomm Programmable Boot Sequencer device. > > Signed-off-by: Anjelique Melendez > --- > .../bindings/soc/qcom/qcom,pbs.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml > new file mode 100644 > index 000000000000..b502ca72266a > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/qcom/qcom,pbs.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. Programmable Boot Sequencer > + > +maintainers: > + - Anjelique Melendez > + > +description: | > + The Qualcomm Technologies, Inc. Programmable Boot Sequencer (PBS) > + supports triggering power up and power down sequences for clients > + upon request. > + > +properties: > + compatible: > + items: > + - enum: > + - qcom,pmi632-pbs > + - const: qcom,pbs > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + pmic@0 { This should be rather just "pmic", because the examples have address-cells=1 and size-cells=1, which is not correct in this context. Anyway: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof