From: Robert Love <rml@tech9.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove suser()
Date: 06 Jun 2002 15:20:23 -0700 [thread overview]
Message-ID: <1023402023.1141.6.camel@sinai> (raw)
In-Reply-To: <20020606214840.GA1190@elf.ucw.cz>
On Thu, 2002-06-06 at 14:48, Pavel Machek wrote:
> > diff -urN linux-2.5.20/include/linux/compatmac.h linux/include/linux/compatmac.h
> > --- linux-2.5.20/include/linux/compatmac.h Sun Jun 2 18:44:41 2002
> > +++ linux/include/linux/compatmac.h Tue Jun 4 13:57:33 2002
> > @@ -102,8 +102,6 @@
> >
> > #define my_iounmap(x, b) (((long)x<0x100000)?0:vfree ((void*)x))
> >
> > -#define capable(x) suser()
> > -
> > #define tty_flip_buffer_push(tty) queue_task(&tty->flip.tqueue, &tq_timer)
>
> This is not right I believe. You want to keep compatibility for older
> kernels.
Someone else said this, too. I must misunderstand the point of this
file... it is used for compatibility with NEW code in OLD kernels?
Confusing that we keep it in the NEW kernel, then. I figured it was
just to keep compatibility in general, or allow OLD code to work in the
new kernels.
If the intention is to use this header with other, older, kernels... and
we really want to keep that in a new kernel... then yes - this bit
should be added back.
Robert Love
next prev parent reply other threads:[~2002-06-06 22:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-04 21:15 Robert Love
2002-06-06 21:48 ` Pavel Machek
2002-06-06 22:20 ` Robert Love [this message]
2002-06-06 22:32 ` Ruth Ivimey-Cook
2002-06-07 5:58 ` Bernd Eckenfels
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1023402023.1141.6.camel@sinai \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®