From: Steven Cole <elenstev@mesatop.com>
To: Martin Josefsson <gandalf@wlug.westbo.se>
Cc: Stephen Lord <lord@sgi.com>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] compile fix for 2.5 kdev_t compatibility macros
Date: 28 Jun 2002 09:24:18 -0600 [thread overview]
Message-ID: <1025277858.11726.136.camel@spc9.esa.lanl.gov> (raw)
In-Reply-To: <1025277008.1643.6.camel@tux>
On Fri, 2002-06-28 at 09:10, Martin Josefsson wrote:
[snip]
>
> And here's one more...
>
> --- linux-2.4.19-rc1/include/linux/kdev_t.h.orig Fri Jun 28 16:59:48 2002
> +++ linux-2.4.19-rc1/include/linux/kdev_t.h Fri Jun 28 17:01:12 2002
> @@ -82,7 +82,7 @@
> #define kdev_same(a,b) ((a) == (b))
> #define kdev_none(d) (!(d))
> #define kdev_val(d) ((unsigned int)(d))
> -#define val_to_kdev(d) ((kdev_t(d))
> +#define val_to_kdev(d) (kdev_t(d))
>
> /*
> As long as device numbers in the outside world have 16 bits only,
>
> --
> /Martin
>
Hmm. It looks like (d) should be cast to (kdev_t).
Here are both fixes (I hope).
Steven
--- linux-2.4.19-rc1/include/linux/kdev_t.h.orig Fri Jun 28 08:31:27 2002
+++ linux-2.4.19-rc1/include/linux/kdev_t.h Fri Jun 28 09:11:39 2002
@@ -81,8 +81,8 @@
#define minor(d) MINOR(d)
#define kdev_same(a,b) ((a) == (b))
#define kdev_none(d) (!(d))
-#define kdev_val(d) ((unsigned int)(d)
-#define val_to_kdev(d) ((kdev_t(d))
+#define kdev_val(d) ((unsigned int)(d))
+#define val_to_kdev(d) ((kdev_t)(d))
/*
As long as device numbers in the outside world have 16 bits only,
prev parent reply other threads:[~2002-06-28 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-28 13:50 Stephen Lord
2002-06-28 14:37 ` Steven Cole
2002-06-28 14:42 ` Stephen Lord
2002-06-28 15:02 ` Andries Brouwer
2002-06-28 15:10 ` Martin Josefsson
2002-06-28 15:24 ` Steven Cole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1025277858.11726.136.camel@spc9.esa.lanl.gov \
--to=elenstev@mesatop.com \
--cc=gandalf@wlug.westbo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=lord@sgi.com \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®