From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751930AbbJGIAO (ORCPT ); Wed, 7 Oct 2015 04:00:14 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:65156 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbbJGIAM (ORCPT ); Wed, 7 Oct 2015 04:00:12 -0400 From: Arnd Bergmann To: Jon Mason , Dave Jiang , Allen Hubbe Cc: linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] NTB: fix 32-bit compiler warning Date: Wed, 07 Oct 2015 09:59:34 +0200 Message-ID: <10263287.Brd9HPYQJD@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:IIzmILVRV4LuIhCPKTMWGxj/sKqwqXka6DHX2vhcULqoK0KG5Jv j47ExXMVBazCFtuPS+WmF1LfZ7WujePg9QOJZwfrsStNgoWs4CeDrHVu4wH2zS/9OZhLvW4 jn8qadhKJNo1CS9sBGLkHhadzB3ZIrlM+Hk6mDpkd19u3J8sTRHyVW3utRpbovnDELb5CXL UXxA7kQgCr0eagU11DSmg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Iuy/LT6H+e8=:H/FxhD2z3/4/tLgLQ0tHv4 j+7o25+XGrPwm5RiReDF4VPRkfTUHR/mcsj0kCBdOK8ELwanBWap9y4xPX9U6g8KYA27sVK6u yPkljPFpdM7+YLFqqj+0TQ1P98Re/daboOynzh0MHrDlRJ5SpBm+BEHKz6Ss78D2/tQWjMn/W h81OjKIvvc+j+mgtDJw5hIUZGR6GYVyx+SxNkk1DY19JfxnR/K7dHKmOxlBL0g7tHKxKliyVF 8UySJSAP7Miy6wsaBriheMIUd+rk2UZnemOrjPjKvV3Lv3ZZ1Ei5jlkqGYvkWFiMFYUByxo8F Lyfso6Gj4Y8V9NYN93iRE4qb6TL89YBgFauSYCqxU79OnMYxBpe9zFRjG8UBmoO61p1HN/CEq XrtPDODqkxb8sfhzXQtgUDnZFtWsnHAbHR1y1QHgcTDB4goWOH8Ca/O84LQu+DYBbRHOa8gk/ rENFRwSQQTu7Aetan1RNQimp5HBizg11il2DJ5Qj7lnPCivRV8/eMc9JHaHnaAmeGlTYUfRly xJch39Ar38bEPl2KXhoOAmkuuN0OJijFda76H66lTM7w7cHI3jyyl6omgnpXAOWbjOouaY3xg LBWZkh4yCmjsNX+l72GBiwF+XuPJuhKNjWha1IhIDoQ+yiMFVI1T5KSA8TS1ULrC6DUFyAzGB zCykTL7PLZ9ors23KwPstToNa9LRTtHFBybf8qTfszsUzl6DoGxNkD2KDwOzV2M+VwbtX/2f6 UXhO3tTgPfctiAio Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org resource_size_t may be 32-bit wide on some architectures, which causes this warning when building the NTB code: drivers/ntb/ntb_transport.c: In function 'ntb_transport_link_work': drivers/ntb/ntb_transport.c:828:46: warning: right shift count >= width of type [-Wshift-count-overflow] The warning is harmless but can be avoided by using the upper_32_bits() macro. Signed-off-by: Arnd Bergmann Fixes: e26a5843f7f5 ("NTB: Split ntb_hw_intel and ntb_transport drivers") --- Found while building ARM allmodconfig diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c index 6e3ee907d186..700f3ae833c2 100644 --- a/drivers/ntb/ntb_transport.c +++ b/drivers/ntb/ntb_transport.c @@ -825,10 +825,10 @@ static void ntb_transport_link_work(struct work_struct *work) size = max_mw_size; spad = MW0_SZ_HIGH + (i * 2); - ntb_peer_spad_write(ndev, spad, (u32)(size >> 32)); + ntb_peer_spad_write(ndev, spad, upper_32_bits(size)); spad = MW0_SZ_LOW + (i * 2); - ntb_peer_spad_write(ndev, spad, (u32)size); + ntb_peer_spad_write(ndev, spad, lower_32_bits(size)); } ntb_peer_spad_write(ndev, NUM_MWS, nt->mw_count);