From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Dinh Nguyen <dinguyen@opensource.altera.com>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: Re: [PATCH 3/3] reset: socfpga: use readl/writel_relaxed
Date: Tue, 05 Jul 2016 13:20:29 +0200 [thread overview]
Message-ID: <10266400.9nrl73J4sT@wuerfel> (raw)
In-Reply-To: <1467713872-4051-3-git-send-email-p.zabel@pengutronix.de>
On Tuesday, July 5, 2016 12:17:52 PM CEST Philipp Zabel wrote:
> This just removes the rmb()/wmb() pair between register read and
> write. Since no relevant reads follow the rmb and no relevant writes
> precede the wmb, they should be safe to remove.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
We should only do this if you are fixing a bug (which you don't mention
in the changelog), or if you can show a relevant performance
improvement. Is this code ever used in a fast path? If it is,
wouldn't that indicate a problem in some driver?
Arnd
next prev parent reply other threads:[~2016-07-05 11:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 10:17 [PATCH 1/3] reset: socfpga: no need to store modrst_offset Philipp Zabel
2016-07-05 10:17 ` [PATCH 2/3] reset: sunxi: use readl/writel_relaxed Philipp Zabel
2016-07-05 10:17 ` [PATCH 3/3] reset: socfpga: " Philipp Zabel
2016-07-05 11:20 ` Arnd Bergmann [this message]
2016-07-05 11:40 ` Philipp Zabel
2016-07-05 12:59 ` Arnd Bergmann
2016-07-05 13:20 ` Philipp Zabel
2016-07-06 16:06 ` [PATCH 1/3] reset: socfpga: no need to store modrst_offset Dinh Nguyen
2016-07-06 16:26 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10266400.9nrl73J4sT@wuerfel \
--to=arnd@arndb.de \
--cc=dinguyen@opensource.altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=p.zabel@pengutronix.de \
--cc=s.trumtrar@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®