From: Robert Love <rml@tech9.net>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] lockd and rpciod do not correctly drop locks
Date: 20 Jul 2002 13:22:05 -0700 [thread overview]
Message-ID: <1027196525.1086.771.camel@sinai> (raw)
Linus,
lockd and rpciod exit without properly relinquishing the locks they
hold. This pisses off the preempt_count debugging in do_exit.
While in this case it is safe since the lock is the BKL, it is unclean
in my opinion.
I also hate seeing the debug message on unmount ;)
Patch is against 2.5.27, please apply.
Robert Love
diff -urN linux-2.5.27/fs/lockd/svc.c linux/fs/lockd/svc.c
--- linux-2.5.27/fs/lockd/svc.c Sat Jul 20 12:11:25 2002
+++ linux/fs/lockd/svc.c Sat Jul 20 12:52:21 2002
@@ -203,6 +203,7 @@
rpciod_down();
/* Release module */
+ unlock_kernel();
MOD_DEC_USE_COUNT;
}
diff -urN linux-2.5.27/net/sunrpc/sched.c linux/net/sunrpc/sched.c
--- linux-2.5.27/net/sunrpc/sched.c Sat Jul 20 12:11:22 2002
+++ linux/net/sunrpc/sched.c Sat Jul 20 12:52:21 2002
@@ -1030,6 +1030,7 @@
wake_up(assassin);
dprintk("RPC: rpciod exiting\n");
+ unlock_kernel();
MOD_DEC_USE_COUNT;
return 0;
}
reply other threads:[~2002-07-20 20:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1027196525.1086.771.camel@sinai \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®