From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Russell King <rmk@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Alan says this needs fixing... (timer/cpu_relax)
Date: 22 Jul 2002 01:54:06 +0100 [thread overview]
Message-ID: <1027299246.17234.121.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <20020721235154.M26376@flint.arm.linux.org.uk>
On Sun, 2002-07-21 at 23:51, Russell King wrote:
> While looking at some stuff, I noticed the following. Alan confirmed
> that this patch is probably a good idea...
>
> --- orig/kernel/timer.c Sun Jul 7 23:21:28 2002
> +++ linux/kernel/timer.c Sun Jul 21 23:50:17 2002
> @@ -176,7 +176,7 @@
> #define timer_enter(t) do { running_timer = t; mb(); } while (0)
> #define timer_exit() do { running_timer = NULL; } while (0)
> #define timer_is_running(t) (running_timer == t)
> -#define timer_synchronize(t) while (timer_is_running(t)) barrier()
> +#define timer_synchronize(t) while (timer_is_running(t)) cpu_relax()
You still need the barrier() as well
prev parent reply other threads:[~2002-07-21 23:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-21 22:51 Russell King
2002-07-22 0:54 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1027299246.17234.121.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®