mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Larson <plars@austin.ibm.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vfs_read/vfs_write small bug fix (2.5.29)
Date: 29 Jul 2002 16:06:52 -0500	[thread overview]
Message-ID: <1027976813.7699.214.camel@plars.austin.ibm.com> (raw)
In-Reply-To: <ai47gn$1dh$1@penguin.transmeta.com>

On Mon, 2002-07-29 at 15:11, Linus Torvalds wrote:

> The fact is, the test for a negative "pos" should not be in
> vfs_read/write at all, since it can only happen for pread/pwrite.
That's where LTP has been seeing it fail.
 
> And pread/pwrite do not even _take_ a "loff_t" argument, they take a
> "off_t", and yet we've just happily claiming they do a loff_t, which
> means that they shouldn't work at all unless by pure changce user space
> happens to put a zero in memory in the right place.
> 
> Cristoph, I think you're the one that did this re-org. I think the code
> is wrong, and the right fix is something along these lines (untested,
> you get brownie-points for testing against some standards test).
> 
> 		Linus

This passes all the LTP pread and pwrite tests.

Thanks,
Paul Larson
Linux Test Project
http://ltp.sourceforge.net


  reply	other threads:[~2002-07-29 21:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-29 18:25 Badari Pulavarty
2002-07-29 19:02 ` Paul Larson
2002-07-29 20:11 ` Linus Torvalds
2002-07-29 21:06   ` Paul Larson [this message]
2002-07-29 21:22     ` Linus Torvalds
2002-07-29 22:06       ` Paul Larson
2002-07-29 22:17         ` Linus Torvalds
2002-07-30  7:37           ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1027976813.7699.214.camel@plars.austin.ibm.com \
    --to=plars@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®