mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gergo Koteles <soyer@irl.hu>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Krzysztof Kozlowski <krzk@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Griffin Kroah-Hartman <griffin.kroah@fairphone.com>,
	Enrico Cic <enrico@privacyrequired.com>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 3/3] arm64: dts: qcom: sm7325-motorola-dubai: Add vibrator support
Date: Wed, 28 Oct 2026 21:32:05 +0100	[thread overview]
Message-ID: <102801f29dbb60d977aabd191a680ab0c3677c22.camel@irl.hu> (raw)
In-Reply-To: <96405224-72e6-4786-b13e-d73134b58ca2@oss.qualcomm.com>

Hi Konrad,

On Wed, 2026-10-28 at 13:04 +0100, Konrad Dybcio wrote:
> On 10/28/26 12:08 PM, Krzysztof Kozlowski wrote:
> > On Tue, Oct 27, 2026 at 11:01:25PM +0100, Gergo Koteles wrote:
> > > Add the required node for haptic playback (Awinic AW86224).
> > > 
> > > Signed-off-by: Gergo Koteles <soyer@irl.hu>
> > > ---
> > >  .../boot/dts/qcom/sm7325-motorola-dubai-common.dtsi   | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/qcom/sm7325-motorola-dubai-common.dtsi b/arch/arm64/boot/dts/qcom/sm7325-motorola-dubai-common.dtsi
> > > index ef91986a1fb9..434846be51d9 100644
> > > --- a/arch/arm64/boot/dts/qcom/sm7325-motorola-dubai-common.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sm7325-motorola-dubai-common.dtsi
> > > @@ -924,6 +924,17 @@ &i2c4 {
> > >  
> > >  	status = "okay";
> > >  
> > > +	vibrator@58 {
> > > +		compatible = "awinic,aw86224";
> > > +		reg = <0x58>;
> > > +
> > > +		interrupts-extended = <&tlmm 47 IRQ_TYPE_EDGE_FALLING>;
> > > +		reset-gpios = <&tlmm 46 GPIO_ACTIVE_LOW>;
> > > +
> > > +		pinctrl-0 = <&aw86224_int_default>;
> > > +		pinctrl-names = "default";
> > > +	};
> > > +
> > >  	wl2864c@29 {
> > 
> > There is no such code.
> > 
> > Please work on mainline, not some fork.
> 
> + please keep the entries sorted
> 
> Konrad

Thanks for the review.

I will sort it by address in the v2.

Best regards,
Gergo

      reply	other threads:[~2026-10-28 20:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27 22:01 [PATCH 0/3] AW86224 haptic driver Gergo Koteles
2026-10-27 22:01 ` [PATCH 1/3] dt-bindings: input: Add compatibility for Awinic AW86224 Gergo Koteles
2026-10-28 11:06   ` Krzysztof Kozlowski
2026-10-28 20:31     ` Gergo Koteles
2026-10-27 22:01 ` [PATCH 2/3] Input: aw86224 - add driver " Gergo Koteles
2026-10-27 22:01 ` [PATCH 3/3] arm64: dts: qcom: sm7325-motorola-dubai: Add vibrator support Gergo Koteles
2026-10-28 11:08   ` Krzysztof Kozlowski
2026-10-28 12:04     ` Konrad Dybcio
2026-10-28 20:32       ` Gergo Koteles [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=102801f29dbb60d977aabd191a680ab0c3677c22.camel@irl.hu \
    --to=soyer@irl.hu \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=enrico@privacyrequired.com \
    --cc=griffin.kroah@fairphone.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®