From: Richard Russon <ldm@flatcap.org>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: Patch: linux-2.5.30/fs/partitions/ldm.c BUG_ON(cond1 || cond2) separation
Date: 06 Aug 2002 00:19:33 +0100 [thread overview]
Message-ID: <1028589573.28848.10.camel@whiskey.something.uk.com> (raw)
In-Reply-To: <20020805140634.A2999@baldur.yggdrasil.com>
Hi Adam,
> linux-2.5.30/fs/partitions/ldm.c had 23 statements
> of the form BUG_ON(condition1 || condition2). This patch changes
> them to:
>
> BUG_ON(condition1);
> BUG_ON(condition2);
Hmm... The only reason I put the BUG_ONs in, is paranoia. I cannot
imagine how they could be tripped, since all the pointers will have
already been checked. If you wish to standardise the way BUG_ON is
used, then OK, change them.
> Could you please let me know if you want to handle submitting it
Please can you submit the patch to Linus.
Cheers,
FlatCap (Rich)
ldm@flatcap.org
prev parent reply other threads:[~2002-08-05 23:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-05 21:06 Adam J. Richter
2002-08-05 23:19 ` Richard Russon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1028589573.28848.10.camel@whiskey.something.uk.com \
--to=ldm@flatcap.org \
--cc=adam@yggdrasil.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®