mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, rogerq@kernel.org, vladimir.oltean@nxp.com,
	hkallweit1@gmail.com, dan.carpenter@linaro.org, horms@kernel.org,
	yuehaibing@huawei.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, srk@ti.com
Subject: Re: [PATCH net-next] net: ethernet: ti: am65-cpsw: Add priv-flag for Switch VLAN Aware mode
Date: Wed, 28 Feb 2024 14:36:55 +0100	[thread overview]
Message-ID: <10287788-614a-4eef-9c9c-a0ef4039b78f@lunn.ch> (raw)
In-Reply-To: <49e531f7-9465-40ea-b604-22a3a7f13d62@ti.com>

> What if there is no kernel behavior associated with it? How can it be mimicked
> then?

Simple. Implement the feature in software in the kernel for
everybody. Then offload it to your hardware.

Your hardware is an accelerator. You use it to accelerate what linux
can already do. If Linux does not have the feature your accelerator
has, that accelerator feature goes unused.

> Please consider the following:
> Untagged packets sent from Software via the corresponding VLAN interfaces will
> be tagged which is the expected behavior. However, if this is offloaded, it will
> imply that even untagged packets that are simply forwarded in the Ethernet
> Switch and never get to software will also have to be tagged by the Ethernet
> Switch. This is not allowing the choice of leaving untagged packets as-is on the
> Ethernet Switch's forwarding path. This patch attempts to allow configuring
> something quite similar to this, where it is possible to *choose* whether or not
> to tag packets being forwarded.

So step back. Forget about your accelerator. Use just a Linux software
bridge. Describe what you want the Linux software bridge to do.

	Andrew

  parent reply	other threads:[~2024-02-28 13:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-27  8:28 Siddharth Vadapalli
2024-02-27 12:39 ` Jiri Pirko
2024-02-28  7:06   ` Siddharth Vadapalli
2024-02-28  8:23     ` Jiri Pirko
2024-02-28 10:04       ` Siddharth Vadapalli
2024-02-28 13:27         ` Jiri Pirko
2024-02-28 13:36         ` Andrew Lunn [this message]
2024-02-29  9:27           ` Siddharth Vadapalli
2024-02-29 10:52             ` Roger Quadros
2024-02-29 11:07               ` Siddharth Vadapalli
2024-02-29 15:33                 ` Andrew Lunn
2024-06-13 13:09                 ` Sverdlin, Alexander
2024-06-13 13:14                 ` Sverdlin, Alexander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10287788-614a-4eef-9c9c-a0ef4039b78f@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=dan.carpenter@linaro.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rogerq@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=srk@ti.com \
    --cc=vladimir.oltean@nxp.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®