Re: [patch] IPMI driver for Linux

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

On Wed, 2002-08-21 at 16:47, Corey Minyard wrote:
> I have been working on an IPMI driver for Linux for MontaVista, and I 
> think it's ready to see the light of day :-).  I would like to see this 
> included in the mainstream kernel eventually.   You can get it at 
> http://home.attbi.com/~minyard.  It should work on any kernel version, 
> although you will have to fix up the Config.in and Makefile, and the 
> Configure.help stuff may not work (it's currently in the 2.4 location).
> 
> The web page has documentation on the driver, and documentation is 
> included in the patch, too.  This is a fairly full-featured driver with 
> a watchdog, panic event generation, full kernel and userland access to 
> the driver, multi-user/multi-interface support, and emulators for other 
> IPMI device drivers.

Comments in general.

It touches user space with spinlocks held -> bad idea
It doesnt check copy_*_user returns instead commenting that some other
driver didnt so it wont - bad idea too
It seems to be allocating a major - can you have > 1 ipmi per host, can
it use misc devices, can it get one registered properly with lanana

Otherwise its way way way nicer than the hideous thing a certain chip
vendor sent me.