From: Bart Van Assche <bvanassche@acm.org>
To: Kiwoong Kim <kwmad.kim@samsung.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
alim.akhtar@samsung.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, kwangwon.min@samsung.com,
hy50.seo@samsung.com, cpgs@samsung.com, h10.kim@samsung.com
Cc: stable@vger.kernel.org, stanleyjhu@google.com
Subject: Re: [PATCH v7 2/2] scsi: ufs: mcq: poll OCS after sq cleanup for device management commands
Date: Thu, 5 Nov 2026 20:53:05 -0800 [thread overview]
Message-ID: <1029b915-d467-4bdc-9ed5-90fd4391e66a@acm.org> (raw)
In-Reply-To: <a1af44cd90dca0dd8a9a06d09a254a4e7e0861b2.1793938245.git.kwmad.kim@samsung.com>
On 11/5/26 8:12 PM, Kiwoong Kim wrote:
> +static enum utp_ocs ufshcd_mcq_poll_ocs(struct ufs_hba *hba,
> + struct ufs_hw_queue *hwq,
> + struct ufshcd_lrb *lrbp)
> +{
> + ufshcd_mcq_poll_cqe_lock(hba, hwq);
> +
> + guard(spinlock_irqsave)(&hwq->cq_lock);
> + return READ_ONCE(lrbp->utr_descriptor_ptr->header.ocs);
> +}
As mentioned before, READ_ONCE() is not necessary since the OCS is read
with cq_lock held.
> means the cleanup has completed.
> The UFSHCI specification says "The host controller shall free up
Please insert a blank line before "The UFSHCI specification says" and
mention the version and section number of the UFSHCI specification.
With the above addressed, feel free to add:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2026-11-06 4:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20261106041300epcas2p4a1028afe27a91c8d6167d422c8be1fb1@epcas2p4.samsung.com>
2026-11-06 4:12 ` [PATCH v7 0/2] scsi: ufs: fix the abort path of device management commands in MCQ mode Kiwoong Kim
[not found] ` <CGME20261106041301epcas2p39724ab936d6c1cb3b5b899f674623975@epcas2p3.samsung.com>
2026-11-06 4:12 ` [PATCH v7 1/2] scsi: ufs: core: skip ABORT TASK for device management commands Kiwoong Kim
2026-11-06 4:53 ` Bart Van Assche
[not found] ` <CGME20261106041303epcas2p19b0c317d409503c833ae125ba91fe053@epcas2p1.samsung.com>
2026-11-06 4:12 ` [PATCH v7 2/2] scsi: ufs: mcq: poll OCS after sq cleanup " Kiwoong Kim
2026-11-06 4:53 ` Bart Van Assche [this message]
2026-11-06 10:43 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1029b915-d467-4bdc-9ed5-90fd4391e66a@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=cpgs@samsung.com \
--cc=h10.kim@samsung.com \
--cc=hy50.seo@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=kwangwon.min@samsung.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
--cc=stanleyjhu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®