mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mukesh Ojha <quic_mojha@quicinc.com>
To: <ye.xingchen@zte.com.cn>, <vkoul@kernel.org>
Cc: <f.fainelli@gmail.com>, <bcm-kernel-feedback-list@broadcom.com>,
	<rjui@broadcom.com>, <sbranden@broadcom.com>,
	<dmaengine@vger.kernel.org>,
	<linux-rpi-kernel@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: use devm_platform_get_and_ioremap_resource()
Date: Thu, 10 Nov 2022 17:24:29 +0530	[thread overview]
Message-ID: <102b69e4-7b1b-23ef-c4f3-a91598546c97@quicinc.com> (raw)
In-Reply-To: <202211101726100208529@zte.com.cn>

Hi,

On 11/10/2022 2:56 PM, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>   drivers/dma/bcm2835-dma.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index 630dfbb01a40..1547f528a58e 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -902,8 +902,7 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
> 
>   	dma_set_max_seg_size(&pdev->dev, 0x3FFFFFFF);
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_ioremap_resource(&pdev->dev, res);
> +	base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>   	if (IS_ERR(base))
>   		return PTR_ERR(base);
> 

LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>


-Mukesh

  reply	other threads:[~2022-11-10 11:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10  9:26 ye.xingchen
2022-11-10 11:54 ` Mukesh Ojha [this message]
2022-11-10 15:43 ` Tudor.Ambarus
  -- strict thread matches above, loose matches on Subject: below --
2022-11-10  8:53 ye.xingchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=102b69e4-7b1b-23ef-c4f3-a91598546c97@quicinc.com \
    --to=quic_mojha@quicinc.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=vkoul@kernel.org \
    --cc=ye.xingchen@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®