From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Dave Jones <davej@suse.de>,
James Simmons <jsimmons@transvirtual.com>,
linux-kernel@vger.kernel.org
Subject: Re: Patch for PC keyboard driver's autorepeat-rate handling
Date: 22 Aug 2002 18:31:02 +0100 [thread overview]
Message-ID: <1030037462.3090.1.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.33L2.0208221153210.672-100000@ida.rowland.org>
On Thu, 2002-08-22 at 16:59, Alan Stern wrote:
> properly? The error is not in the program; it's in the kernel's
> handling of the KDKBDREP ioctl. This patch fixes the following three
> mistakes:
>
> The .rate member of struct kbd_repeat is actually a repeat
> _period_ measured in msec; the driver interprets it as a
> repeat _rate_ in characters per second.
>
> The driver returns the _prior_ values of the rate and delay
> settings rather than the _current_ values.
>
> The driver looks for an exact match for the rate and delay
> values rather than using the closest match.
Since its done what it does now since about 1991, it would be better to
fix the documentation if in fact there is an error.
> Incidentally, does anybody know why drivers/char/pc_keyb.c hasn't been
> moved to the arch/i386 part of the directory tree?
"PC" keyboard and PS/2 mouse hardware can appear on almost any system,
even on plug in PCI cards.
next prev parent reply other threads:[~2002-08-22 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-22 15:59 Alan Stern
2002-08-22 17:31 ` Alan Cox [this message]
2002-08-22 19:37 ` Andries Brouwer
2002-08-22 20:16 ` Alan Cox
2002-08-22 20:39 ` Andries Brouwer
2002-08-22 20:57 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030037462.3090.1.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=davej@suse.de \
--cc=jsimmons@transvirtual.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®