From: Paul Larson <plars@linuxtestproject.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: lkml <linux-kernel@vger.kernel.org>, davem@redhat.com
Subject: [PATCH] Fix compile error in ip_nat_helper.c
Date: 29 Aug 2002 09:47:15 -0500 [thread overview]
Message-ID: <1030632439.5187.27.camel@plars.austin.ibm.com> (raw)
In-Reply-To: <20020829.071452.16869863.davem@redhat.com>
On Thu, 2002-08-29 at 09:14, David S. Miller wrote:
> From: Paul Larson <plars@austin.ibm.com>
> Date: 29 Aug 2002 09:05:14 -0500
>
> The nightly bk testing last night found a new build error last night
> with ip_nat_helper
>
> Just some __FUNCTION__ string pasting that newer GCC doesn't like.
> Feel free to submit a patch.
I guess this is one of the "pasters" noted in:
ChangeSet@1.552, 2002-08-28 14:53:09-07:00,
torvalds@penguin.transmeta.com
Add some fascist code to trap __FUNCTION__ pasting, fix up
some more pasters.
Please apply. Thanks,
Paul Larson
Linux Test Project
http://www.linuxtestproject.org
-------------------------------
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.553 -> 1.554
# net/ipv4/netfilter/ip_nat_helper.c 1.5 -> 1.6
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 02/08/29 plars@austin.ibm.com 1.554
# Fix compile failure in ip_nat_helper.c
# --------------------------------------------
#
diff -Nru a/net/ipv4/netfilter/ip_nat_helper.c b/net/ipv4/netfilter/ip_nat_helper.c
--- a/net/ipv4/netfilter/ip_nat_helper.c Thu Aug 29 10:25:10 2002
+++ b/net/ipv4/netfilter/ip_nat_helper.c Thu Aug 29 10:25:10 2002
@@ -382,9 +382,9 @@
const char *tmp = me->me->name;
if (strlen(tmp) + 6 > MODULE_MAX_NAMELEN) {
- printk(__FUNCTION__ ": unable to "
+ printk("%s: unable to "
"compute conntrack helper name "
- "from %s\n", tmp);
+ "from %s\n",__FUNCTION__, tmp);
return -EBUSY;
}
tmp += 6;
@@ -467,7 +467,7 @@
&& ct_helper->me) {
__MOD_DEC_USE_COUNT(ct_helper->me);
} else
- printk(__FUNCTION__ ": unable to decrement usage count"
- " of conntrack helper %s\n", me->me->name);
+ printk("%s: unable to decrement usage count"
+ " of conntrack helper %s\n",__FUNCTION__, me->me->name);
}
}
prev parent reply other threads:[~2002-08-29 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-29 14:05 LTP Nightly BK Test Failure - ip_nat_helper Paul Larson
2002-08-29 14:14 ` David S. Miller
2002-08-29 14:47 ` Paul Larson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030632439.5187.27.camel@plars.austin.ibm.com \
--to=plars@linuxtestproject.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®