From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tomas Szepe <szepe@pinerecords.com>
Cc: pwaechtler@mac.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 6/41 sound/oss/pss.c - convert cli to spinlocks
Date: 30 Aug 2002 11:56:58 +0100 [thread overview]
Message-ID: <1030705018.3196.7.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <20020830074730.GF19611@louise.pinerecords.com>
On Fri, 2002-08-30 at 08:47, Tomas Szepe wrote:
> > static pss_confdata *devc = &pss_data;
> ^ ^
> > +static spinlock_t lock=SPIN_LOCK_UNLOCKED;
>
> > if (!pss_put_dspword(devc, *data++)) {
> ^
> > + spin_unlock_irqrestore(&lock,flags);
>
>
> Would you please take care not to clutter the original sources with
> lines in a different C formatting style?
When you've ported that much code to a new locking mechanism then you
can moan. If he wants to take on the old OSS code and making it work in
the 2.5 universe as far as I (as the ex OSS code maintainer) am concened
he can format it how he likes
prev parent reply other threads:[~2002-08-30 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-29 19:56 pwaechtler
2002-08-30 7:47 ` Tomas Szepe
2002-08-30 10:56 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030705018.3196.7.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=pwaechtler@mac.com \
--cc=szepe@pinerecords.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®