mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Libershteyn, Vladimir" <vladimir.libershteyn@hp.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org
Subject: RE: Problem on a kernel driver(SuSE, SMP)
Date: 05 Sep 2002 00:44:33 +0100	[thread overview]
Message-ID: <1031183073.2796.149.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <8C18139EDEBC274AAD8F2671105F0E8E012704D7@cacexc02.americas.cpqcorp.net>

On Wed, 2002-09-04 at 18:56, Libershteyn, Vladimir wrote:

> 	//
> 	// sleep until data is ready
> 	//
> 	down_interruptible(&a->sem[enumerator]);

Suppose its interrupted. You dont check that and handle it..


> 	board_address = ((unsigned long *)((unsigned char *)a->vaddr + OutputQueueFilled));
> 	length = *board_address;

You can't poke around in memory directly either. Yes it works on x86 but
unless you use ioremap combined with readl and friends it wont work they
way you expect on ia64, x86-64, ...



  parent reply	other threads:[~2002-09-04 23:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-04 17:56 Libershteyn, Vladimir
2002-09-04 21:36 ` Christoph Hellwig
2002-09-04 23:44 ` Alan Cox [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-09-05  0:26 Libershteyn, Vladimir
2002-09-04 23:52 Libershteyn, Vladimir
2002-09-05  0:05 ` Alan Cox
2002-09-04 22:20 Libershteyn, Vladimir
2002-09-04 18:35 Libershteyn, Vladimir
2002-09-04 17:53 Libershteyn, Vladimir
2002-09-04 18:25 ` Richard B. Johnson
2002-09-04 16:54 Libershteyn, Vladimir
2002-09-04 17:27 ` Richard B. Johnson
2002-09-04 17:40 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1031183073.2796.149.camel@irongate.swansea.linux.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vladimir.libershteyn@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®