From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Zwane Mwaikambo <zwane@mwaikambo.name>,
Linus Torvalds <torvalds@transmeta.com>,
Robert Love <rml@tech9.net>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][RFC] per isr in_progress markers
Date: 10 Sep 2002 16:32:35 +0100 [thread overview]
Message-ID: <1031671955.1537.87.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <11228.1031670308@redhat.com>
On Tue, 2002-09-10 at 16:05, David Woodhouse wrote:
>
> mingo@elte.hu said:
> > this is something i have a 0.5 MB patch for that touches a few
> > hundred drivers. I can dust it off if there's demand - it will break
> > almost nothing because i've done the hard work of adding the default
> > 'no work was done' bit to every driver's IRQ handler.
>
> Note that you can also survive IRQ storms this way -- if all handlers
> returned 'no work was done' and you get over $N irqs per second, disable
> that IRQ for a while.
You can do that without touching any drivers and its better that way
Firstly the "no work was done" check is insufficient if work is being
done but the IRQ rate is too high to keep up.
Secondly the check means mangling all the drivers when you can establish
if work was done anyway by checking bh/userspace has also had some run
time.
I'm all for surviving IRQ storms on a level triggered IRQ, but do it
purely on interrupt rate and measured system progress not on some
assumption that the driver knows what its doing.
next prev parent reply other threads:[~2002-09-10 15:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-07 22:34 Zwane Mwaikambo
2002-09-08 7:55 ` Ingo Molnar
2002-09-08 8:15 ` Ingo Molnar
2002-09-08 10:38 ` Zwane Mwaikambo
2002-09-08 13:31 ` Zwane Mwaikambo
2002-09-08 16:59 ` Zwane Mwaikambo
2002-09-08 22:01 ` Linus Torvalds
2002-09-08 23:03 ` Jeff Garzik
2002-09-09 6:49 ` bert hubert
2002-09-09 16:24 ` Linus Torvalds
2002-09-09 10:06 ` Ingo Molnar
2002-09-09 15:06 ` Linus Torvalds
2002-09-09 18:44 ` Ingo Molnar
2002-09-09 18:53 ` Linus Torvalds
2002-09-09 19:37 ` Zwane Mwaikambo
2002-09-09 19:23 ` Ingo Molnar
2002-09-09 20:05 ` Zwane Mwaikambo
2002-09-09 20:08 ` Andrew Morton
2002-09-10 15:05 ` David Woodhouse
2002-09-10 15:32 ` Alan Cox [this message]
2002-09-10 22:37 ` Gérard Roudier
2002-09-09 19:38 ` Maciej W. Rozycki
2002-09-10 11:55 ` Stephan von Krawczynski
2002-09-10 18:07 ` Gunther Mayer
2002-09-10 18:38 ` Zwane Mwaikambo
2002-09-10 7:46 ` Rogier Wolff
2002-09-08 10:57 ` Zwane Mwaikambo
2002-09-09 20:40 ` Alan Cox
2002-09-09 20:48 ` Andre Hedrick
2002-09-10 17:47 ` Zwane Mwaikambo
2002-09-09 9:49 zwane
2002-09-09 14:34 ` Robert Love
2002-09-09 18:23 ` Zwane Mwaikambo
2002-09-09 10:13 zwane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1031671955.1537.87.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rml@tech9.net \
--cc=torvalds@transmeta.com \
--cc=zwane@mwaikambo.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®