mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xi Ruoyao <xry111@xry111.site>
To: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>,
	 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/6] cpufreq: intel_pstate: Do not update global.turbo_disabled after initialization
Date: Wed, 05 Jun 2024 13:21:38 +0800	[thread overview]
Message-ID: <1031cc4e4b507628531d9115ce7e4bc588dbab1c.camel@xry111.site> (raw)
In-Reply-To: <651d11578646200cdb0a91c46ed09a22f29e94a0.camel@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 6035 bytes --]

On Tue, 2024-06-04 at 09:56 -0700, srinivas pandruvada wrote:
> > > With such a delay, I am not sure how this even worked before.

It didn't work out of box but it worked after manually writing 0 to
no_turbo after 20 seconds, see
https://bugzilla.kernel.org/show_bug.cgi?id=218702.

> > > Can you revert the patch in question and use kernel dynamic debug
> > > dyndbg="file intel_pstate.c +p" kernel command line and collect log
> > > for
> > > 30 seconds?

Attached.  The related part seems:

[    0.553606] intel_pstate: Intel P-state driver initializing
[    0.553630] intel_pstate: controlling: cpu 0
[    0.553640] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    0.553642] intel_pstate: cpu:0 min_policy_perf:4 max_policy_perf:31
[    0.553643] intel_pstate: cpu:0 global_min:0 global_max:44
[    0.553644] intel_pstate: cpu:0 max_perf_ratio:31 min_perf_ratio:4
[    0.553680] intel_pstate: controlling: cpu 1
[    0.553702] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    0.553703] intel_pstate: cpu:1 min_policy_perf:4 max_policy_perf:31
[    0.553704] intel_pstate: cpu:1 global_min:0 global_max:44
[    0.553705] intel_pstate: cpu:1 max_perf_ratio:31 min_perf_ratio:4
[    0.553742] intel_pstate: controlling: cpu 2
[    0.553763] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    0.553764] intel_pstate: cpu:2 min_policy_perf:4 max_policy_perf:31
[    0.553765] intel_pstate: cpu:2 global_min:0 global_max:44
[    0.553766] intel_pstate: cpu:2 max_perf_ratio:31 min_perf_ratio:4
[    0.553809] intel_pstate: controlling: cpu 3
[    0.553830] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    0.553831] intel_pstate: cpu:3 min_policy_perf:4 max_policy_perf:31
[    0.553831] intel_pstate: cpu:3 global_min:0 global_max:44
[    0.553832] intel_pstate: cpu:3 max_perf_ratio:31 min_perf_ratio:4
[    0.553868] intel_pstate: controlling: cpu 4
[    0.553892] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    0.553893] intel_pstate: cpu:4 min_policy_perf:4 max_policy_perf:31
[    0.553894] intel_pstate: cpu:4 global_min:0 global_max:44
[    0.553895] intel_pstate: cpu:4 max_perf_ratio:31 min_perf_ratio:4
[    0.553943] intel_pstate: controlling: cpu 5
[    0.553967] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    0.553968] intel_pstate: cpu:5 min_policy_perf:4 max_policy_perf:31
[    0.553968] intel_pstate: cpu:5 global_min:0 global_max:44
[    0.553969] intel_pstate: cpu:5 max_perf_ratio:31 min_perf_ratio:4
[    0.554009] intel_pstate: controlling: cpu 6
[    0.554034] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    0.554035] intel_pstate: cpu:6 min_policy_perf:4 max_policy_perf:31
[    0.554036] intel_pstate: cpu:6 global_min:0 global_max:44
[    0.554037] intel_pstate: cpu:6 max_perf_ratio:31 min_perf_ratio:4
[    0.554077] intel_pstate: controlling: cpu 7
[    0.554098] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    0.554099] intel_pstate: cpu:7 min_policy_perf:4 max_policy_perf:31
[    0.554099] intel_pstate: cpu:7 global_min:0 global_max:44
[    0.554100] intel_pstate: cpu:7 max_perf_ratio:31 min_perf_ratio:4
[    0.554104] intel_pstate: HWP enabled
[    2.183669] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    2.183675] intel_pstate: cpu:6 min_policy_perf:4 max_policy_perf:31
[    2.183677] intel_pstate: cpu:6 global_min:4 global_max:44
[    2.183679] intel_pstate: cpu:6 max_perf_ratio:31 min_perf_ratio:4
[    2.183710] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    2.183711] intel_pstate: cpu:4 min_policy_perf:4 max_policy_perf:31
[    2.183713] intel_pstate: cpu:4 global_min:4 global_max:44
[    2.183715] intel_pstate: cpu:4 max_perf_ratio:31 min_perf_ratio:4
[    2.183742] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    2.183744] intel_pstate: cpu:2 min_policy_perf:4 max_policy_perf:31
[    2.183745] intel_pstate: cpu:2 global_min:4 global_max:44
[    2.183747] intel_pstate: cpu:2 max_perf_ratio:31 min_perf_ratio:4
[    2.183773] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    2.183775] intel_pstate: cpu:0 min_policy_perf:4 max_policy_perf:31
[    2.183776] intel_pstate: cpu:0 global_min:4 global_max:44
[    2.183777] intel_pstate: cpu:0 max_perf_ratio:31 min_perf_ratio:4
[    2.183803] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    2.183805] intel_pstate: cpu:7 min_policy_perf:4 max_policy_perf:31
[    2.183806] intel_pstate: cpu:7 global_min:4 global_max:44
[    2.183807] intel_pstate: cpu:7 max_perf_ratio:31 min_perf_ratio:4
[    2.183831] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    2.183833] intel_pstate: cpu:5 min_policy_perf:4 max_policy_perf:31
[    2.183834] intel_pstate: cpu:5 global_min:4 global_max:44
[    2.183836] intel_pstate: cpu:5 max_perf_ratio:31 min_perf_ratio:4
[    2.183862] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    2.183864] intel_pstate: cpu:3 min_policy_perf:4 max_policy_perf:31
[    2.183865] intel_pstate: cpu:3 global_min:4 global_max:44
[    2.183867] intel_pstate: cpu:3 max_perf_ratio:31 min_perf_ratio:4
[    2.183893] intel_pstate: set_policy cpuinfo.max 3100000 policy->max 3100000
[    2.183895] intel_pstate: cpu:1 min_policy_perf:4 max_policy_perf:31
[    2.183896] intel_pstate: cpu:1 global_min:4 global_max:44
[    2.183898] intel_pstate: cpu:1 max_perf_ratio:31 min_perf_ratio:4

> > I think that it worked because the MSR was read every time
> > intel_pstate ran, so it got updated at one point and stayed that way.
> 
> But here HWP in active mode is getting used. So it should have fewer
> request calls to set accept via cpufreq set_policy()
> 
>  callback or with some HWP interrupt.

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

[-- Attachment #2: dmesg.gz --]
[-- Type: application/gzip, Size: 21506 bytes --]

  reply	other threads:[~2024-06-05  5:21 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25 17:00 [PATCH v1 0/6] intel_pstate: Turbo disabled handling rework Rafael J. Wysocki
2024-03-25 17:01 ` [PATCH v1 1/6] cpufreq: intel_pstate: Fold intel_pstate_max_within_limits() into caller Rafael J. Wysocki
2024-04-01 20:06   ` srinivas pandruvada
2024-03-25 17:02 ` [PATCH v1 2/6] cpufreq: intel_pstate: Do not update global.turbo_disabled after initialization Rafael J. Wysocki
2024-06-02  3:21   ` Xi Ruoyao
2024-06-02  4:03     ` srinivas pandruvada
2024-06-02  4:25       ` Xi Ruoyao
2024-06-02 13:40         ` srinivas pandruvada
2024-06-02 16:07           ` Xi Ruoyao
2024-06-02 23:11             ` srinivas pandruvada
2024-06-03 13:12               ` Xi Ruoyao
2024-06-03 17:11                 ` srinivas pandruvada
2024-06-03 17:44                   ` Xi Ruoyao
2024-06-03 18:32                     ` Rafael J. Wysocki
2024-06-03 18:47                       ` srinivas pandruvada
2024-06-04  4:10                         ` srinivas pandruvada
2024-06-04  4:31                         ` srinivas pandruvada
2024-06-04  9:30                           ` Xi Ruoyao
2024-06-04 10:29                             ` srinivas pandruvada
2024-06-04 10:32                               ` Xi Ruoyao
2024-06-04 16:41                                 ` srinivas pandruvada
2024-06-04 16:46                                   ` Rafael J. Wysocki
2024-06-04 16:56                                     ` srinivas pandruvada
2024-06-05  5:21                                       ` Xi Ruoyao [this message]
2024-06-05 12:05                                         ` srinivas pandruvada
2024-06-07 15:04                                           ` Rafael J. Wysocki
2024-06-07 15:18                                             ` srinivas pandruvada
2024-06-08  9:30                                               ` Xi Ruoyao
2024-03-25 17:03 ` [PATCH v1 3/6] cpufreq: intel_pstate: Rearrange show_no_turbo() and store_no_turbo() Rafael J. Wysocki
2024-03-25 17:04 ` [PATCH v1 4/6] cpufreq: intel_pstate: Read global.no_turbo under READ_ONCE() Rafael J. Wysocki
2024-03-25 17:05 ` [PATCH v1 5/6] cpufreq: intel_pstate: Replace three global.turbo_disabled checks Rafael J. Wysocki
2024-03-25 17:06 ` [PATCH v1 6/6] cpufreq: intel_pstate: Update the maximum CPU frequency consistently Rafael J. Wysocki
2024-03-27 18:08   ` srinivas pandruvada
2024-03-28 11:26     ` Rafael J. Wysocki
2024-03-28 19:02   ` [PATCH v1.1 " Rafael J. Wysocki
2024-04-02  8:46 ` [PATCH v1 0/6] intel_pstate: Turbo disabled handling rework srinivas pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1031cc4e4b507628531d9115ce7e4bc588dbab1c.camel@xry111.site \
    --to=xry111@xry111.site \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®