BUG: sym53c8xx_2 and highmem_io

[Todd Inglett <tinglett@vnet.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

I've been having an interesting experience getting sym53c8xx_2 working
on ppc64 now that highio is in place.  Of course ppc64 doesn't need
highio, and it does set blk_nohighio = 1 in setup_arch().  So the
sym53c8xx driver works.

However, sym53c8xx_2 fails because after calling scsi_register() in its
attach it blindly slams highmem_io on (in sym_glue.c).  Is this
correct?  It seems to me that it should just leave it alone since
scsi_register already handled that.

I might be misunderstanding something here.  Is there anything else a
64-bit arch must do for highio?  I found we also weren't setting max_pfn
which seemed bad...though maybe irrelevant.

The trivial patch to fix it is attached, but I haven't tested it on a
system that supports highio.

-todd


[-- Attachment #2: highio.sym2.patch --]
[-- Type: text/x-diff, Size: 613 bytes --]

Index: drivers/scsi/sym53c8xx_2/sym_glue.c
===================================================================
RCS file: /cvs/linuxppc64/linuxppc64_2_4/drivers/scsi/sym53c8xx_2/sym_glue.c,v
retrieving revision 1.2
diff -u -r1.2 sym_glue.c
--- drivers/scsi/sym53c8xx_2/sym_glue.c	23 Aug 2002 18:43:46 -0000	1.2
+++ drivers/scsi/sym53c8xx_2/sym_glue.c	16 Sep 2002 17:45:54 -0000
@@ -2140,7 +2140,7 @@
 	instance->max_cmd_len	= 16;
 #endif
 	instance->select_queue_depths = sym53c8xx_select_queue_depths;
-	instance->highmem_io	= 1;
+	/* instance->highmem_io	= 1; */
 
 	SYM_UNLOCK_HCB(np, flags);