From: Robert Love <rml@tech9.net>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] schedule() in_atomic() fix
Date: 18 Sep 2002 00:46:43 -0400 [thread overview]
Message-ID: <1032324404.4593.764.camel@phantasy> (raw)
Linus,
Attached patch fixes the scheduler in_atomic() problem with kernel
preemption enabled (and is also working - when kernel preemption is on,
it finds a couple issues during boot).
I hope this approach is to your liking.
Patch is against current BK, please apply.
Robert Love
diff -urN linux-2.5.36/kernel/sched.c linux/kernel/sched.c
--- linux-2.5.36/kernel/sched.c Tue Sep 17 20:58:48 2002
+++ linux/kernel/sched.c Wed Sep 18 00:41:09 2002
@@ -940,9 +940,6 @@
struct list_head *queue;
int idx;
- if (unlikely(in_atomic()))
- BUG();
-
#if CONFIG_DEBUG_HIGHMEM
check_highmem_ptes();
#endif
@@ -950,8 +947,20 @@
preempt_disable();
prev = current;
rq = this_rq();
-
release_kernel_lock(prev);
+
+ /*
+ * Test if we are atomic. Since do_exit() needs to call into
+ * schedule() atomically, we ignore that for now. Otherwise,
+ * whine if we are scheduling when we should not be.
+ */
+ if (likely(current->state != TASK_ZOMBIE)) {
+ if (unlikely((preempt_count() & ~PREEMPT_ACTIVE) != 1)) {
+ printk(KERN_ERR "scheduling while non-atomic!\n");
+ dump_stack();
+ }
+ }
+
prev->sleep_timestamp = jiffies;
spin_lock_irq(&rq->lock);
next reply other threads:[~2002-09-18 4:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-18 4:46 Robert Love [this message]
[not found] ` <3D88099C.9B5F044D@digeo.com>
2002-09-18 5:09 ` Robert Love
2002-09-18 15:06 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1032324404.4593.764.camel@phantasy \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®