From: Robert Love <rml@tech9.net>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] schedule() in_atomic() check
Date: 20 Sep 2002 16:05:15 -0400 [thread overview]
Message-ID: <1032552318.962.830.camel@phantasy> (raw)
Linus,
Resend of patch to make the in_atomic() check in schedule() actually
work. You merged the PREEMPT_ACTIVE bits, we just need to handle the
exit() case correctly.
Tested with and without CONFIG_PREEMPT -- works like a charm.
Patch is against current BK.
Robert Love
diff -urN linux-2.5.37/kernel/sched.c linux/kernel/sched.c
--- linux-2.5.37/kernel/sched.c Fri Sep 20 11:20:32 2002
+++ linux/kernel/sched.c Fri Sep 20 15:49:05 2002
@@ -940,8 +940,17 @@
struct list_head *queue;
int idx;
- if (unlikely(in_atomic()))
- BUG();
+ /*
+ * Test if we are atomic. Since do_exit() needs to call into
+ * schedule() atomically, we ignore that path for now.
+ * Otherwise, whine if we are scheduling when we should not be.
+ */
+ if (likely(current->state != TASK_ZOMBIE)) {
+ if (unlikely(in_atomic())) {
+ printk(KERN_ERR "bad: scheduling while atomic!\n");
+ dump_stack();
+ }
+ }
#if CONFIG_DEBUG_HIGHMEM
check_highmem_ptes();
reply other threads:[~2002-09-20 20:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1032552318.962.830.camel@phantasy \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®