From: Robert Love <rml@tech9.net>
To: Ingo Molnar <mingo@elte.hu>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
torvalds@transmeta.com, akpm@zip.com.au, ingo@redhat.com,
linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: Re: [PATCH] de-xchg fork.c
Date: 23 Sep 2002 14:30:34 -0400 [thread overview]
Message-ID: <1032805833.25756.17.camel@phantasy> (raw)
In-Reply-To: <Pine.LNX.4.44.0209232026320.28863-100000@localhost.localdomain>
On Mon, 2002-09-23 at 14:31, Ingo Molnar wrote:
> the attached patch (against BK-curr) fixes all xchg()'s and a preemption
> bug.
Thanks, Ingo.
> --- linux/kernel/fork.c.orig Mon Sep 23 20:28:36 2002
> +++ linux/kernel/fork.c Mon Sep 23 20:30:02 2002
> @@ -64,11 +64,12 @@
> } else {
> int cpu = smp_processor_id();
>
> - tsk = xchg(task_cache + cpu, tsk);
> + tsk = task_cache[cpu];
> if (tsk) {
> free_thread_info(tsk->thread_info);
> kmem_cache_free(task_struct_cachep,tsk);
> }
> + task_cache[cpu] = current;
> }
> }
I think you need get/put_cpu() here, too?
Robert Love
next prev parent reply other threads:[~2002-09-23 18:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-23 1:06 Rusty Russell
2002-09-22 0:48 ` Pavel Machek
2002-09-23 18:31 ` Ingo Molnar
2002-09-23 18:30 ` Robert Love [this message]
2002-09-23 18:56 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1032805833.25756.17.camel@phantasy \
--to=rml@tech9.net \
--cc=akpm@zip.com.au \
--cc=ingo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@transmeta.com \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®