On Thu, 2002-09-26 at 23:21, Shaya Potter wrote: > asmlinkage long sys_getpid(void) > { > /* This is SMP safe - current->pid doesn't change */ > return current->tgid; > } > > I assume we are returning tgid so that no matter what thread of a > multithreaded program calls getpid we return the same value, and that > the comment with pid is old and should have been updated when it was > changed to return tgid. A student in my Operating Systems class pointed > this out, so I figured no harm in pointing the possible bug out. Yes, you are correct, the comment is wrong. We switched to returning the tgid in early 2.4 when CLONE_THREAD was introduced. The tgid and pid are identical unless CLONE_THREAD was used. Attached patch fixes the typo and adds some comments explaining this. Marcelo, patch is against 2.4.20-pre8, please apply. Robert Love