From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Alan Cox <alan@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.5.40-ac1
Date: 03 Oct 2002 16:17:36 +0100 [thread overview]
Message-ID: <1033658256.28814.0.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <3D9C5827.70703@colorfullife.com>
On Thu, 2002-10-03 at 15:45, Manfred Spraul wrote:
> > o Fix abuse of set_bit in winbond-840 (me)
>
> Were there bug reports, Have you tested the change?
Yes and no - I don't have an 840
> I think the cpu_to_le32 is wrong.
>
> On big endian computers, the nic is set into a big-endian mode, and it
> did work with set_bit on my power mac. Unfortunately, I don't have
> access to it right now.
The checks I did were that it seemed to produce the same data in both
cases. So if it was wrong before (using set_bit) its probably wrong now.
next prev parent reply other threads:[~2002-10-03 15:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-03 14:45 Manfred Spraul
2002-10-03 14:50 ` David S. Miller
2002-10-03 15:18 ` Manfred Spraul
2002-10-03 15:15 ` David S. Miller
2002-10-03 15:48 ` Alan Cox
2002-10-03 15:53 ` Manfred Spraul
2002-10-03 15:17 ` Alan Cox [this message]
2002-10-03 15:34 ` Manfred Spraul
-- strict thread matches above, loose matches on Subject: below --
2002-10-02 23:38 Greg Ungerer
2002-10-03 14:17 ` Christoph Hellwig
2002-10-03 14:20 ` Alan Cox
2002-10-03 14:51 ` Christoph Hellwig
2002-10-03 15:25 ` Alan Cox
2002-10-03 15:28 ` Christoph Hellwig
2002-10-03 15:31 ` Greg Ungerer
2002-10-03 19:16 ` Rik van Riel
2002-10-03 23:44 ` Greg Ungerer
2002-10-04 0:32 ` Rik van Riel
2002-10-02 22:18 Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1033658256.28814.0.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®