From: Robert Love <rml@tech9.net>
To: marcelo@conectiva.com.br
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] 2.4: get_pid() typo fix
Date: 06 Oct 2002 15:44:59 -0400 [thread overview]
Message-ID: <1033933500.11402.4466.camel@phantasy> (raw)
Magnificent Marcelo,
Fix a typo in the comment of getpid() - we return current->tgid these
days, not current->pid. Additionally, add some new comments explaining
exactly why we return the tgid and how this works.
Patch is against 2.4.20-pre9, please apply.
Robert Love
diff -urN linux-2.4.20-pre9/kernel/timer.c linux/kernel/timer.c
--- linux-2.4.20-pre9/kernel/timer.c 2002-10-06 14:57:20.000000000 -0400
+++ linux/kernel/timer.c 2002-10-06 15:03:31.000000000 -0400
@@ -740,10 +740,18 @@
* The Alpha uses getxpid, getxuid, and getxgid instead. Maybe this
* should be moved into arch/i386 instead?
*/
-
+
+/**
+ * sys_getpid - return the thread group id of the current process
+ *
+ * Note, despite the name, this returns the tgid not the pid. The tgid and
+ * the pid are identical unless CLONE_THREAD was specified on clone() in
+ * which case the tgid is the same in all threads of the same group.
+ *
+ * This is SMP safe as current->tgid does not change.
+ */
asmlinkage long sys_getpid(void)
{
- /* This is SMP safe - current->pid doesn't change */
return current->tgid;
}
next reply other threads:[~2002-10-06 19:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-06 19:44 Robert Love [this message]
2002-10-07 13:40 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1033933500.11402.4466.camel@phantasy \
--to=rml@tech9.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®