From: Steve Lord <lord@sgi.com>
To: Andrew Morton <akpm@digeo.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Badari Pulavarty <pbadari@us.ibm.com>
Subject: Re: [patch] 512-byte alignment for O_DIRECT I/O
Date: 08 Oct 2002 11:34:29 -0500 [thread overview]
Message-ID: <1034094869.16054.7.camel@jen.americas.sgi.com> (raw)
In-Reply-To: <3DA211B8.325C32BA@digeo.com>
On Mon, 2002-10-07 at 17:59, Andrew Morton wrote:
>
> This patch from Badari is passing all testing now.
>
.....
> +++ 2.5.41-akpm/fs/xfs/linux/xfs_aops.c Mon Oct 7 15:50:21 2002
> @@ -688,8 +688,8 @@ linvfs_direct_IO(
> {
> struct inode *inode = file->f_dentry->d_inode->i_mapping->host;
>
> - return generic_direct_IO(rw, inode, iov, offset, nr_segs,
> - linvfs_get_blocks_direct);
> + return generic_direct_IO(rw, inode, inode->i_sb->s_bdev,
> + iov, offset, nr_segs, linvfs_get_blocks_direct);
> }
>
> STATIC int
>
Actually this part is broken for XFS - it will work for most cases,
but not for realtime files, in this case there is another bdev involved.
I just have to work out how to get to it from here...... the getblock
code knows enough to set it in the bh, but at this level we do not.
Steve
--
Steve Lord voice: +1-651-683-3511
Principal Engineer, Filesystem Software email: lord@sgi.com
next prev parent reply other threads:[~2002-10-08 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-07 22:59 Andrew Morton
2002-10-08 16:34 ` Steve Lord [this message]
2002-10-08 16:54 ` Andrew Morton
2002-10-08 17:21 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1034094869.16054.7.camel@jen.americas.sgi.com \
--to=lord@sgi.com \
--cc=akpm@digeo.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®