Re: [PATCH] 2.5.41, cciss (3 of 3)

[Arjan van de Ven <arjanv@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 998 bytes --]

On Fri, 2002-10-11 at 16:10, Stephen Cameron wrote:
> 
> Wait up to 20 seconds for polled commands to complete.  A certain multiport
> storage box needs this.
> 
> diff -urN linux-2.5.41-p/drivers/block/cciss.c linux-2.5.41-q/drivers/block/cciss.c
> --- linux-2.5.41-p/drivers/block/cciss.c	Wed Oct  9 15:22:14 2002
> +++ linux-2.5.41-q/drivers/block/cciss.c	Wed Oct  9 15:54:35 2002
> @@ -1318,9 +1318,9 @@
>          unsigned long done;
>          int i;
>  
> -        /* Wait (up to 2 seconds) for a command to complete */
> +        /* Wait (up to 20 seconds) for a command to complete */
>  
> -        for (i = 200000; i > 0; i--) {
> +        for (i = 2000000; i > 0; i--) {
>                  done = hba[ctlr]->access.command_completed(hba[ctlr]);
>                  if (done == FIFO_EMPTY) {
>                          udelay(10);     /* a short fixed delay */

ugh 20 seconds udelay....

why can't you sleep here ?
(and yes 20 seconds WILL trigger watchdogs!)


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]