From: Steve Lord <lord@sgi.com>
To: Andrew Morton <akpm@digeo.com>
Cc: Hugh Dickins <hugh@veritas.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [patch] remove BKL from inode_setattr
Date: 14 Oct 2002 11:49:00 -0500 [thread overview]
Message-ID: <1034614140.30453.6.camel@jen.americas.sgi.com> (raw)
In-Reply-To: <3DAAF3B2.24158D49@digeo.com>
On Mon, 2002-10-14 at 11:41, Andrew Morton wrote:
> >
> > XFS deliberately does not take the BKL - anywhere. Our setattr
> > code is doing its own locking. You just added the BKL to a
> > bunch of xfs operations which do not need it. Now, vmtruncate
> > may need it, itself, but if vmtruncate does not, then the xfs
> > callout from vmtruncate certainly does not.
> >
>
> Sorry, but that is standard "bkl migration" methodology. You had it
> before, so you get it after. It is not my role to change XFS locking.
But you did .... my point was, XFS does not use the BKL at all, has
never needed it and never will. The setattr call you added it to
meant you added it to chown, chmod etc. When the BKL was migrated
down below the vfs layer in all those places I deliberately did not
add it to the XFS calls.
>
> Anyway, I don't think these patches are going anywhere.
No problem,
Steve
--
Steve Lord voice: +1-651-683-3511
Principal Engineer, Filesystem Software email: lord@sgi.com
next prev parent reply other threads:[~2002-10-14 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-14 5:02 Andrew Morton
2002-10-14 6:09 ` Hugh Dickins
2002-10-14 6:34 ` Andrew Morton
2002-10-14 14:07 ` Steve Lord
2002-10-14 16:41 ` Andrew Morton
2002-10-14 16:49 ` Steve Lord [this message]
2002-10-14 14:41 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1034614140.30453.6.camel@jen.americas.sgi.com \
--to=lord@sgi.com \
--cc=akpm@digeo.com \
--cc=hugh@veritas.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®