From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jens Axboe <axboe@suse.de>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Pavel Machek <pavel@ucw.cz>,
benh@kernel.crashing.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: swsusp: don't eat ide disks
Date: 04 Nov 2002 13:37:54 +0000 [thread overview]
Message-ID: <1036417074.1113.34.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <20021104094413.GF13587@suse.de>
On Mon, 2002-11-04 at 09:44, Jens Axboe wrote:
> It's probably not a good idea to rely on ata drives that also speak
> atapi, to my knowledge only a few old WDC drives ever did that. Since we
> are basically moving to the point where "SCSI" commands is the
> commandset that the block layer uses to make drivers do things for it,
> I had the idea of doing a rq -> taskfile conversion for ide. Just for
> simple things like read/write and sync cache, basically stuff that is
> directly translatable. That would make Linus' example actually work, and
> it would also make the direct read/write programs using SG_IO work on
> IDE drives as well.
Going beyond IDE it might be cleaner to be able to do
struct bio_command_ops
{
eject: idedisk_eject,
suspend: idedisk_suspend,
identify: idedisk_identify,
...
[maybe even read:/write: in some cases
like smart scsi raids]
}
that way IDE disk and all the other weirdass drives can have -one-
command parser not the twenty differently buggy ones we have now simply
by doing
if(rq_is_command(rq))
bio_do_command(rq, &bio_command_ops);
Its also very convenient as we can add fields to the structure and then
to drives without breaking the API and without so much updating
Alan
next prev parent reply other threads:[~2002-11-04 13:09 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-02 18:47 Pavel Machek
2002-11-02 19:39 ` Linus Torvalds
2002-11-02 20:06 ` Alan Cox
2002-11-02 20:25 ` Pavel Machek
2002-11-02 22:04 ` Alan Cox
2002-11-03 20:11 ` Pavel Machek
2002-11-04 1:04 ` Rik van Riel
2002-11-06 12:34 ` Pavel Machek
2002-11-03 14:57 ` benh
2002-11-03 16:25 ` Alan Cox
2002-11-03 16:24 ` benh
2002-11-03 16:36 ` Alan Cox
2002-11-04 7:47 ` benh
2002-11-03 20:12 ` Pavel Machek
2002-11-03 21:33 ` Alan Cox
2002-11-03 22:09 ` Pavel Machek
2002-11-03 22:41 ` Alan Cox
2002-11-03 22:27 ` Pavel Machek
2002-11-03 23:56 ` Alan Cox
2002-11-04 8:16 ` benh
2002-11-04 13:33 ` Alan Cox
2002-11-03 22:48 ` Linus Torvalds
2002-11-03 22:53 ` Linus Torvalds
2002-11-04 8:08 ` benh
2002-11-04 14:59 ` Linus Torvalds
2002-11-04 15:27 ` Benjamin Herrenschmidt
2002-11-04 9:44 ` Jens Axboe
2002-11-04 13:37 ` Alan Cox [this message]
2002-11-03 22:56 ` Pavel Machek
2002-11-03 23:38 ` Linus Torvalds
2002-11-06 13:57 ` Pavel Machek
2002-11-04 7:57 ` benh
2002-11-04 9:39 ` Jens Axboe
2002-11-04 9:50 ` Jens Axboe
2002-11-07 13:06 ` David Woodhouse
2002-11-07 16:15 ` Pavel Machek
2002-11-07 16:18 ` David Woodhouse
2002-11-07 20:52 ` Pavel Machek
2002-11-07 18:26 Grover, Andrew
2002-11-07 22:25 ` David Woodhouse
2002-11-08 11:09 ` Benjamin Herrenschmidt
2002-11-10 11:54 ` Pavel Machek
2002-11-11 6:38 ` David Woodhouse
2002-11-12 17:41 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1036417074.1113.34.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®