mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Linus Torvalds <torvalds@transmeta.com>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] NCR53C9x ESP: C99 designated initializers
Date: 10 Nov 2002 14:38:00 +0000	[thread overview]
Message-ID: <1036939080.1005.10.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <Pine.GSO.4.21.0211101124070.20578-100000@vervain.sonytel.be>

On Sun, 2002-11-10 at 10:27, Geert Uytterhoeven wrote:
ut soft reset.
>   */
> -int esp_reset(Scsi_Cmnd *SCptr, unsigned int how)
> +int esp_reset(Scsi_Cmnd *SCptr)
>  {
>  	struct NCR_ESP *esp = (struct NCR_ESP *) SCptr->host->hostdata;
>  
>  	(void) esp_do_resetbus(esp, esp->eregs);
> -	return SCSI_RESET_PENDING;
> +	wait_event(esp->reset_queue, (esp->resetting_bus == 0));
> +
> +	return SUCCESS;
>  }

Reset is called with the lock held surely. How can the wait_event be
right ? 


  reply	other threads:[~2002-11-10 14:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-03 10:46 Geert Uytterhoeven
2002-11-03 13:13 ` Christoph Hellwig
2002-11-03 14:28   ` Geert Uytterhoeven
2002-11-03 14:33     ` Christoph Hellwig
2002-11-10 10:27       ` Geert Uytterhoeven
2002-11-10 14:38         ` Alan Cox [this message]
2002-11-11  9:31           ` Geert Uytterhoeven
2002-11-11  9:43             ` David S. Miller
2002-11-11 13:05               ` Alan Cox
2002-11-11 17:24                 ` Linus Torvalds
2002-11-11 17:43                   ` Arjan van de Ven
2002-11-11 20:31                   ` Doug Ledford
2002-11-11 22:48                   ` Alan Cox
2002-11-11 20:35                 ` Doug Ledford
2002-11-11 21:01                   ` Linus Torvalds
2002-11-11 21:24                     ` Doug Ledford
2002-11-11 18:30 J.E.J. Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1036939080.1005.10.camel@irongate.swansea.linux.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=geert@linux-m68k.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®