From: Arjan van de Ven <arjanv@redhat.com>
To: Valdis.Kletnieks@vt.edu
Cc: Alessandro Suardi <alessandro.suardi@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: 2.5.5[01]]: Xircom Cardbus broken (PCI resource collisions)
Date: 13 Dec 2002 11:10:24 +0100 [thread overview]
Message-ID: <1039774224.1449.0.camel@laptop.fenrus.com> (raw)
In-Reply-To: <200212122247.gBCMlHgY011021@turing-police.cc.vt.edu>
On Thu, 2002-12-12 at 23:47, Valdis.Kletnieks@vt.edu wrote:
> Been there. Done that. Does the attached patch help? It did for me.
>
> /Valdis
>
>
> ----
>
> --- drivers/pcmcia/cardbus.c.dist 2002-12-03 01:49:29.000000000 -0500
> +++ drivers/pcmcia/cardbus.c 2002-12-03 01:50:23.000000000 -0500
> @@ -283,8 +283,6 @@
> dev->hdr_type = hdr & 0x7f;
>
> pci_setup_device(dev);
> - if (pci_enable_device(dev))
> - continue;
>
> strcpy(dev->dev.bus_id, dev->slot_name);
>
> @@ -302,6 +300,8 @@
> pci_writeb(dev, PCI_INTERRUPT_LINE, irq);
> }
>
> + if (pci_enable_device(dev))
> + continue;
> device_register(&dev->dev);
> pci_insert_device(dev, bus);
> }
interesting. BUT aren't we writing to the device 3 lines before where
you add the pci_enable_device()? That sounds like a bad plan to me ;(
next prev parent reply other threads:[~2002-12-13 10:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-12 22:47 Valdis.Kletnieks
2002-12-13 0:43 ` Greg KH
2002-12-13 4:22 ` Valdis.Kletnieks
2002-12-13 10:10 ` Arjan van de Ven [this message]
2002-12-13 13:45 ` Valdis.Kletnieks
2002-12-13 16:17 ` Petr Konecny
[not found] ` <200212131633.gBDGX0617899@anxur.fi.muni.cz>
2002-12-13 17:18 ` Valdis.Kletnieks
2002-12-13 17:36 ` Dave Jones
2002-12-13 18:46 ` Valdis.Kletnieks
2002-12-14 0:18 ` Zwane Mwaikambo
2002-12-13 19:03 ` Jeff Garzik
2002-12-14 3:43 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2002-12-14 17:28 ALESSANDRO.SUARDI
2002-12-16 14:54 ` Valdis.Kletnieks
2002-12-12 14:10 Alessandro Suardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1039774224.1449.0.camel@laptop.fenrus.com \
--to=arjanv@redhat.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=alessandro.suardi@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®