From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: Jeff Chua <jchua@fedex.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
rusty@rustcorp.com.au
Subject: Re: 2.5.51 ide module problem
Date: 13 Dec 2002 10:31:48 +0000 [thread overview]
Message-ID: <1039775508.25121.10.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <20021212235934.A770@baldur.yggdrasil.com>
On Fri, 2002-12-13 at 07:59, Adam J. Richter wrote:
> --- linux-2.5.51/drivers/pci/pci.c 2002-12-09 18:45:52.000000000 -0800
> +++ linux/drivers/pci/pci.c 2002-12-09 19:03:18.000000000 -0800
> @@ -736,6 +736,7 @@
> EXPORT_SYMBOL(isa_bridge);
> #endif
>
> +EXPORT_SYMBOL(pci_enable_device_bars);
> EXPORT_SYMBOL(pci_enable_device);
> EXPORT_SYMBOL(pci_disable_device);
> EXPORT_SYMBOL(pci_max_busnr);
This one looks correct.
> diff -r -u linux-2.5.51/drivers/ide/Kconfig linux/drivers/ide/Kconfig
> --- linux-2.5.51/drivers/ide/Kconfig 2002-12-09 18:45:56.000000000 -0800
> +++ linux/drivers/ide/Kconfig 2002-11-27 18:23:46.000000000 -0800
> @@ -199,7 +199,7 @@
> depends on BLK_DEV_IDE
>
> config BLK_DEV_CMD640
> - bool "CMD640 chipset bugfix/support"
> + tristate "CMD640 chipset bugfix/support"
Please don't do this. You can't "load" the workaround meaningfully for
this device
> config BLK_DEV_GENERIC
> - bool "Generic PCI IDE Chipset Support"
> + tristate "Generic PCI IDE Chipset Support"
> depends on PCI && BLK_DEV_IDEPCI
Probably ok. I need to review that.
> -obj-$(CONFIG_BLK_DEV_IDE) += ide-io.o ide-probe.o ide-geometry.o ide-iops.o ide-taskfile.o ide.o ide-lib.o
> +obj-$(CONFIG_BLK_DEV_IDE) += ide-mod.o
> +ide-mod-objs += ide-io.o ide-probe.o ide-geometry.o ide-iops.o ide-taskfile.o ide.o ide-lib.o
Looks ok
> diff -r -u linux-2.5.51/drivers/ide/pci/cmd640.c linux/drivers/ide/pci/cmd640.c
> --- linux-2.5.51/drivers/ide/pci/cmd640.c 2002-12-09 18:46:22.000000000 -0800
> +++ linux/drivers/ide/pci/cmd640.c 2002-11-27 18:24:00.000000000 -0800
> @@ -102,6 +102,7 @@
No (as per comment above)
> --- linux-2.5.51/drivers/ide/ide-probe.c 2002-12-09 18:46:10.000000000 -0800
> +++ linux/drivers/ide/ide-probe.c 2002-12-12 23:50:58.000000000 -0800
> @@ -831,7 +831,8 @@
> ide_toggle_bounce(drive, 1);
>
> #ifdef CONFIG_BLK_DEV_IDE_TCQ_DEFAULT
> - HWIF(drive)->ide_dma_queued_on(drive);
> + if (HWIF(drive)->ide_dma_queued_on)
> + HWIF(drive)->ide_dma_queued_on(drive);
Looks right
At a first glance (and its only that), drop out the CMD640 changes and
the rest seems ok. Please check it on a few setups and also non modular
since you've changed the probe bits a little.
Alan
next prev parent reply other threads:[~2002-12-13 9:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-11 6:50 Adam J. Richter
2002-12-11 7:07 ` Jeff Chua
2002-12-11 8:41 ` Adam J. Richter
[not found] ` <Pine.LNX.4.50.0212111711180.4632-200000@boston.corp.fedex.com>
2002-12-13 7:59 ` Adam J. Richter
2002-12-13 10:31 ` Alan Cox [this message]
2002-12-14 6:45 ` Jeff Chua
-- strict thread matches above, loose matches on Subject: below --
2002-12-18 14:18 Adam J. Richter
2002-12-18 14:14 Adam J. Richter
2002-12-18 16:07 ` Alan Cox
2002-12-18 19:50 ` Jeff Chua
2002-12-18 22:43 ` Alan Cox
2002-12-18 22:06 ` Andre Hedrick
2002-12-11 5:49 Jeff Chua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1039775508.25121.10.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=adam@yggdrasil.com \
--cc=jchua@fedex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®