From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4322D15A86D for ; Mon, 29 Jun 2026 12:25:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782735937; cv=none; b=W8hRZSAkC0d4EtU4eiHgnA5I0OA1nkE3Pbjz2rFaTSr3sR8sjfnqRHJGXz4o1CDkAKLpjn61PSiW/zKsrWL4zTI0VkGo+7d/HbZNxGiPrI2yYXXdFeOzixt74gsVcucJ0oawo+ipu60/jbn7MM1wUoINBU7CC7sfS3K+li9l0Ag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782735937; c=relaxed/simple; bh=uajltYhiMvusyvh+KCcSZfqXGw6iS9PcZKLJJkUndEI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=erzjQCoJhLEcSq5CaayitEpEHrjuzSO27GBECpW4VkaE7//aZI81f83hFNbI7r0JCczq/uNOKPjELi172QPOawoF0RTw6jOB9S6k3mfgRmqElIAdCQ+5xY40XA92xbjabAUoGQBJxsIcBUq4cDBGECjATF/5LIENS4fZGjM228g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Wo+z5gOY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H46L2LRp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Wo+z5gOY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H46L2LRp" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65TAT3D52601595 for ; Mon, 29 Jun 2026 12:25:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= R/gDFeWX25oeLKFNlAnH1g6BTev6I4bSVAzgfKi7gk4=; b=Wo+z5gOYrS0vd62c zTV/FZNjbV4MKJE690kAo6uKKQAOcZv9NmX0GbBaXuwAqFb/5HIdzljlpZhbMicZ qe+muqU7FUOQx5fQKXtRJ018+laghoGdIRD3qD/tYmzkuEgvs1MvPlydlu525DXG hutBvy0EJQ8Xhwp1HdMbnnvXHAaJAidRrMC5QjarNmlyguGpduTGdr/CnP5e379J 1nw+KyD6et14B1j/YyLkubLmMIhFqKYRheHLchnfMImdyYKI5gYieYXET+47tQgV Uu19J6fgarmjK66cVGj4SkRVbVTBWAO2WRkPETkW9crDWnIt68JMusM2wECjOFGp 2UhnDw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3nnw8s9k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 12:25:35 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c08e9c344so859701cf.3 for ; Mon, 29 Jun 2026 05:25:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782735934; x=1783340734; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=R/gDFeWX25oeLKFNlAnH1g6BTev6I4bSVAzgfKi7gk4=; b=H46L2LRpPNKkv/6oAPN6xgp94w+L8RlGH1k579larV17ihmBWL8fiEuhXFha1+zZbJ GZ1Djw8a/j6q27lzXiUv6o4634ML0kaiCSTMM6C+AzmDDW50WWbX3pQNq3pKeMn47tsZ WM9QqThTmLlIIDs823SLIYU+GUcZJMbGFSCG5F0OpkEb6GQVqmsz64gai/ykAROSSbUd tErQy9KXwBB3b5tvhE4TjqSYz2IKNoRUeYu7j48GSVZlIwGbvfst0wB36037BQIs8h8D oduorUJz1b+WdQWPgJEVQaQKJLvo6LQlxqIqCVDcL8YmZuPvwO25jL158t0Cxzffnbns vzQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782735934; x=1783340734; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=R/gDFeWX25oeLKFNlAnH1g6BTev6I4bSVAzgfKi7gk4=; b=GDJHmskkzhgw8UTwGoqe/CDURrF6R/O+Fk/iV7lJqfEln8ZsNbx7m2QfP/nkwvQ19z 1HI1j3MSLvBHa7YIg80Iupr7+h6lzv4JNAuqp0IsySOWNpKBCE7pzt0+O3d5bxOM5iP7 pfTRN86/tiqBaCHgbXe1zdmxurI05J3wpK/+QgztWrdND5A6jCkdTTq8j7dlbfh0Lc9P hcN0ebXaeMpxnoF11FD7p4OAi099np1fFV8gsuLxijmcS+QdXAl8HOHZPVEj+MExxWB3 K2xSNPo3UGTawZHHYWq7pGicL8zfft65icEnb6+6oZadvMfCEyYH6qeTj1tTLrzcdxVi xeKw== X-Forwarded-Encrypted: i=1; AFNElJ+B1rflcIvC7BUSug3lXQ8cf9G7rw+enS/BL0UzaC2vSBHpvZdThGG2241A/zL2Eh7ZkGlBeQMnB6Jeuzc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzg4PwPOA3E7vcCcg9MKcBQ1Ouzln/ymeOLisU3go/Fxu31h5YE ebqscKUun4tgwUsWBoWPzVfC0kDF/3X5nqd2t9TzlyMMzjlrGutQlYi9M5My5OBsF+qMHkSJkFz A9FTIHGafWMNs36aKXlr9/Ki22SzUeznyHHlGX67e7GMrl1aO7WeWkmH7XmPI3xIBEeU= X-Gm-Gg: AfdE7cnuS9UMSvA+sbGMKwVqYMrxjjbUM+ngU5J5FTmkYf3MCx3je4UbAKZS3aiUrPl v6INmzRHW3WJ2CcRyrFb0LejBpVrfVZUrn5hHJ+qyGBn9JVMzOHzOWsrwyl7bKh6PA/QnvVmspq 7T0J17tLkr3aiYcrA00FQbtBio/qSbGgppjhTFw8kFaNismFEtt+oxEVnwIxG2wFa4n05ZJMZ6D DmJuMabx8PIDnHSPoEPF4EfQHtIcE/5IFtNQV4WAPcmr38BeN8t3Oipt8tvGNbHmEtIscZZ2cv7 uGjv/CTSgFhRPzMqK1MklfHFzfh8sSlAt2OThjjOkMw3qYI5InP7kR3BHFD6PO8LzAwUnJ1nQK5 yQ0P4ZI8Htrb5H3BkoyicOA+5WdMv7Nmd3hg= X-Received: by 2002:ac8:7f13:0:b0:51a:8c9b:6492 with SMTP id d75a77b69052e-51a8c9b95eemr96932701cf.9.1782735934331; Mon, 29 Jun 2026 05:25:34 -0700 (PDT) X-Received: by 2002:ac8:7f13:0:b0:51a:8c9b:6492 with SMTP id d75a77b69052e-51a8c9b95eemr96932421cf.9.1782735933791; Mon, 29 Jun 2026 05:25:33 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c11fbbe8118sm768760066b.24.2026.06.29.05.25.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 05:25:32 -0700 (PDT) Message-ID: <103bb3bd-7099-46d0-b0ad-baec1493d742@oss.qualcomm.com> Date: Mon, 29 Jun 2026 14:25:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 7/8] arm64: dts: qcom: mahua: Add QREF regulator supplies to TCSR To: Qiang Yu Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krishna.chundru@oss.qualcomm.com References: <20260621-tcsr_qref_0622-v6-0-c939c22ded0c@oss.qualcomm.com> <20260621-tcsr_qref_0622-v6-7-c939c22ded0c@oss.qualcomm.com> <8e4ea76e-f1c0-4dfd-8477-35e01ac0ba0d@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDEwMiBTYWx0ZWRfXxy1MPI8bSjnx JVASlCoy1TNk4F+kxzPovIC9CDIz0OVd2kYB/S3Xm9MawZojfc241TQfqFalLdITvQu7wybEuyZ XM36COJt4hbh+f5xJyvMGAW7JQPFd3M= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDEwMiBTYWx0ZWRfXyGlhvU8+MQqA YTSNFRo5JTtO2aTmaTRB9ojS9JoaupZbWgHCYLkCW4tC2g/v3dVJZAnP9m+h8RBzqUTvUO9Wq8L lMf+4/RS+OiuaPopzDUGIbU2pxaWpxzrRmkbtRWRVy9U/69aWNn8aTlU+GAVT0qGGp9fUfbHnoy KC74YfcvdWwAE24hh9sucLFWfhnWHsHA0TIANq9iUYrmFLS2qvBo37kaVzUN4Q3CWMQC1xv65Js dZATGQnjfMXjm4L4w549VjuLII8ue7xWJ/YOVs2SZKQzJdsmwUUV7vThHiXm3XvTzSYkLTMDwbe 5owMb+whUtUSNLJbu9rYeGYprxZooDhCeQFqRUCUUG5UJ7nbTjjOouj3zSG9Tk2u7PL8n2aJfgP QaBhbCypQcsT9PO027XYm7QSDaBVG5DLUrbJuz7VG1glPn1aoOp2Hs1PjoY30OfswZj1p2HMbsp wnwVNKotFjKMWk7tobg== X-Proofpoint-GUID: kF75bUzqtNl8Pgk1_qZPbnvbmjjzIl3c X-Authority-Analysis: v=2.4 cv=cefiaHDM c=1 sm=1 tr=0 ts=6a42643f cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=sBmxciXZafjqAzqtsYoA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: kF75bUzqtNl8Pgk1_qZPbnvbmjjzIl3c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290102 On 6/29/26 2:23 PM, Qiang Yu wrote: > On Mon, Jun 29, 2026 at 12:34:10PM +0200, Konrad Dybcio wrote: >> On 6/22/26 3:31 PM, Qiang Yu wrote: >>> On Mon, Jun 22, 2026 at 02:18:54PM +0200, Konrad Dybcio wrote: >>>> On 6/22/26 7:11 AM, Qiang Yu wrote: >>>>> Mahua has a different PCIe QREF topology from glymur. Override the TCSR >>>>> compatible to qcom,mahua-tcsr in mahua.dtsi, and wire up the required >>>>> LDO supplies for the PCIe clkref paths on the CRD board. >>>>> >>>>> Signed-off-by: Qiang Yu >>>>> --- >>>>> arch/arm64/boot/dts/qcom/mahua-crd.dts | 15 +++++++++++++++ >>>>> arch/arm64/boot/dts/qcom/mahua.dtsi | 4 ++++ >>>>> 2 files changed, 19 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/mahua-crd.dts b/arch/arm64/boot/dts/qcom/mahua-crd.dts >>>>> index 9c8244e892dd..8b42f5174b31 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/mahua-crd.dts >>>>> +++ b/arch/arm64/boot/dts/qcom/mahua-crd.dts >>>>> @@ -19,3 +19,18 @@ / { >>>>> model = "Qualcomm Technologies, Inc. Mahua CRD"; >>>>> compatible = "qcom,mahua-crd", "qcom,mahua"; >>>>> }; >>>>> + >>>>> +&tcsr { >>>>> + vdda-qrefrpt0-0p9-supply = <&vreg_l2f_e1_0p83>; >>>>> + vdda-qrefrpt1-0p9-supply = <&vreg_l2f_e1_0p83>; >>>>> + vdda-qrefrpt2-0p9-supply = <&vreg_l2f_e1_0p83>; >>>>> + vdda-qrefrpt3-0p9-supply = <&vreg_l1f_e1_0p82>; >>>>> + vdda-qrefrpt4-0p9-supply = <&vreg_l2h_e0_0p72>; >>>>> + vdda-qrefrpt5-0p9-supply = <&vreg_l2h_e0_0p72>; >>>>> + vdda-qrefrx1-0p9-supply = <&vreg_l2f_e1_0p83>; >>>>> + vdda-qrefrx2-0p9-supply = <&vreg_l2f_e1_0p83>; >>>>> + vdda-qrefrx3-0p9-supply = <&vreg_l2h_e0_0p72>; >>>>> + vdda-qreftx1-0p9-supply = <&vreg_l1f_e1_0p82>; >>>>> + vdda-refgen3-0p9-supply = <&vreg_l1f_e1_0p82>; >>>>> + vdda-refgen3-1p2-supply = <&vreg_l4f_e1_1p08>; >>>> >>>> The supplies are correct, but QREF uses refgen4 on Mahua >>>> >>> >>> The instance is REFGEN4, but its regulator name is refgen3_xxx. Do you >>> think rename the supplies as vdda-refgen4-0p9-supply is better? >> >> Ah, I overlooked this. Maybe 4 could be better here, since the supplies >> that end up being assigned there match what we call refgen4 on Glymur. >> >> But there's no good answer, both options are terrible. Let's add a >> comment somewhere (in bindings?) describing this mess, perhaps like: >> >> # On Mahua, the REFGEN4 block is supplied through pads named REFGEN3 > > Okay, it's better to metion this in commit msg. Doing so in both is good too! Konrad